Bug 343592 - Build broken in CVS HEAD
Build broken in CVS HEAD
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-06-01 13:34 UTC by Don Scorgie
Modified: 2006-06-04 21:27 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Don Scorgie 2006-06-01 13:34:54 UTC 
Building epiphany as part of jhbuild, using Mozilla 1.8.  Build fails with:

EphySidebar.cpp:117: error: no 'nsresult EphySidebar::AddMicrosummaryGenerator(const char*)' member function declared in class 'EphySidebar'

Fresh checkout of epiphany from HEAD.
Comment 1 Christian Persch 2006-06-01 17:03:23 UTC 
Which gecko version did configure detect? Should be 1.8.1. If not, can you attach config.log ?
Comment 2 Don Scorgie 2006-06-02 11:35:42 UTC 
Configure detected gecko version 1.8.1.
Comment 3 Christian Persch 2006-06-02 16:09:51 UTC 
And HAVE_GECKO_1_8_1 is defined in the generated config.h?
Comment 4 Don Scorgie 2006-06-04 20:45:07 UTC 
Yup, GECKO_1_8_1 is defined in config.h:

(from config.h):
/* Define if we have gecko 1.7 */
#define HAVE_GECKO_1_7 1

/* Define if we have gecko 1.8 */
#define HAVE_GECKO_1_8 1

/* Define if we have gecko 1.8.1 */
#define HAVE_GECKO_1_8_1 1

/* Define if we have gecko 1.9 */
/* #undef HAVE_GECKO_1_9 */
Comment 5 Christian Persch 2006-06-04 21:27:14 UTC 
Ok I see the problem. The API change was reverted on 1.8 branch:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/dom/public/idl/sidebar/nsISidebar.idl&rev=MOZILLA_1_8_BRANCH&mark=1.3.10.4
I'll fix the define to HAVE_GECKO_1_9 in cvs (we could do some #ifdef MOZILLA_1_8_BRANCH-ing but since it's unimplemented I won't bother).
Note You need to log in before you can comment on or make changes to this bug.