After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343563 - Export nautilus-sendto-plugin.h
Export nautilus-sendto-plugin.h
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
Depends on:
Blocks:
 
 
Reported: 2006-06-01 07:05 UTC by Dimitur Kirov
Modified: 2009-09-23 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
export nautilus-sendto.pc and nautilus-sendto-plugin.h (1.71 KB, patch)
2006-06-01 08:05 UTC, Dimitur Kirov
needs-work Details | Review

Description Dimitur Kirov 2006-06-01 07:05:58 UTC
Currently it is not possible to build new plugins, unless the file is manually copied to the plugin source dir.
Comment 1 Dimitur Kirov 2006-06-01 08:05:44 UTC
Created attachment 66585 [details] [review]
export nautilus-sendto.pc and nautilus-sendto-plugin.h
Comment 2 Bastien Nocera 2006-08-21 21:47:38 UTC
I don't think the API is stable enough to be used outside nautilus-sendo itself.
Comment 3 Saleem Abdulrasool 2008-04-14 19:32:43 UTC
Could require the external application to define NAUTILUS_SENDTO_API_SUBJECT_TO_CHANGE similar to DBUS in order to include the header.
Comment 4 Bastien Nocera 2008-04-16 14:03:27 UTC
We'd need versioning added to the plugin structure before we can export it. We'd also need to version the directories used to store the plugins.

(In reply to comment #3)
> Could require the external application to define
> NAUTILUS_SENDTO_API_SUBJECT_TO_CHANGE similar to DBUS in order to include the
> header.

Which serves absolutely no help when the applications are actually using it, and nautilus-sendto starts crashing because of third-party plugins.
Comment 5 Bastien Nocera 2009-01-10 13:49:51 UTC
An update to say that I'd be happy to add such a patch now, as long as gtk-doc support is included as well, so some documentation is available for writing new plugins.
Comment 6 Bastien Nocera 2009-04-26 11:14:55 UTC
We also need to add a "gettext-package" member of the plugin structure, for plugins to be translated. The package name needs to be remembered in the plugin_list, and the call to gtk_tree_store_set() in nautilus-sendto-command.c changed to use the correct gettext package.
Comment 7 Bastien Nocera 2009-09-23 11:58:19 UTC
Comment on attachment 66585 [details] [review]
export nautilus-sendto.pc and nautilus-sendto-plugin.h

Committed something similar to master.
Comment 8 Bastien Nocera 2009-09-23 13:20:48 UTC
All fixed in master.