After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343108 - Consider replacing changing menu-item text with checkboxes or a pair of items
Consider replacing changing menu-item text with checkboxes or a pair of items
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Bruno Boaventura
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2006-05-27 13:47 UTC by Wouter Bolsterlee (uws)
Modified: 2006-11-15 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Wouter Bolsterlee (uws) 2006-05-27 13:47:13 UTC
The "Show on all workspaces" menuitem in a window's context menu should be a checkbox, just like the "Always on top" item. Right now the item changes it text (BAD UI! BAD UI! BAD UI! ;->) when it is selected.
Comment 1 Elijah Newren 2006-05-27 14:37:12 UTC
Dude, you need to upgrade.  "Show on all workspaces" was renamed quite a while ago.  Still valid though, and, of course, there's the same problem in libwnck for the right-click on task menu.

Opinion of the usability experts?
Comment 2 Wouter Bolsterlee (uws) 2006-05-27 20:33:44 UTC
Elijah, I'm running HEAD but in the nl_NL locale so I made an ad-hoc translation without checking the source; I'm lazy and it's irrelevant ;-)
Comment 3 Elijah Newren 2006-05-28 01:10:33 UTC
Oh, I see.  Sorry for jumping to conclusions.  :)
Comment 4 Calum Benson 2006-06-16 17:11:12 UTC
Following the HIG's guidance here, if we're moving away from the changing-label model, there's more likely a case for using two radiobutton menu items instead of a checkbox, as the two states aren't naturally opposite.  I.e. if I had "Always on visible workspace" unchecked, that could mean "never on visible workspace", or "always on other workspaces", or "sometimes on visible workspace depending on the outcome of a random number" :)

http://developer.gnome.org/projects/gup/hig/2.0/menus-design.html#menu-item-types

Comment 5 Rob Adams 2006-06-16 18:21:08 UTC
The random number solution is clearly correct here.
Comment 6 Björn Lindqvist 2006-08-24 15:49:58 UTC
What about the menu changing itself depending on what you choose? If you select "Always on Visible Workspace," then the item "move to workspace to the right/left/up/down" and the submenu "move to another workspace" disappears. Does something need to be done about that? It is not 100% robust IMHO.
Comment 7 Elijah Newren 2006-09-18 22:14:00 UTC
Also worth noting is that minimize/unminimize (okay, so that one is only noticable in libwnck) and maximize/unmaximize are two other items in the menu that change form.  If we're going to get rid of changing text in the menu, those need to be modified too.
Comment 8 Bruno Boaventura 2006-10-04 23:59:02 UTC
I'd like to implement this.
Can I use radiobuttons?
Comment 9 Bruno Boaventura 2006-10-17 02:05:23 UTC
I have been attached a patch to fix it and bug #342123.

http://bugzilla.gnome.org/attachment.cgi?id=74851&action=view
Comment 10 Bruno Boaventura 2006-10-17 02:37:53 UTC
Elijah:

If you commit this, I'll open a bug to fix it in libwnck too.
Comment 11 Bruno Boaventura 2006-10-17 22:29:04 UTC
Patch updated... (I forgot a detail in previous...)

http://bugzilla.gnome.org/attachment.cgi?id=74901&action=view