GNOME Bugzilla – Bug 343090
Most brushes and all patterns appear renameable but aren't
Last modified: 2016-11-16 14:18:10 UTC
If you have the brushes or patterns dockable set to list view, you can double click on an item to edit its name. When you hit enter it returns to the original name (except for VBRs) The patterns and brushes I use all reside in writable directories and are themselves writable. I'm aware of the awkwardness involved internally with resaving the changed GBR, GIH, or PAT files. I just thought that it ought to be in the bug list.
Someone should port the save routines from the brush and pattern plug-ins to the core.
Perhaps only "display name" could be edited (not physical filename) and stored in tags.xml ?
I think a redesign of the data system to make it less awkward would have to involve changes bigger than that. Someone should collect a rough set of requirements and present them for discussion on gimp-developer. Then when we know what we need to do, we can come up with a design.
i cant save custom names for brush either
Yeah, this happens for brushes in non-writeable directories. This bug is about a possible change, but IIRC not much has been done yet.
I've been talking about this with José Americo Gobbo - a brazilian designer, and we should take a look before the new release - it is a more or less serious issues. Please note that the "rough set of requirements" on the mailing list is ongoing, mostly in a thread started by Prokoudine in feb. 2014.
Is important to have the same instances to administrate the resources through the resource list of the Gimp... Raster brushes (.gih and .gbr) and Patterns are linked to the imaging flow where the the 'alias name' and the 'file name' are given in different steps of the resource creation. The filename can be administered, after resource creation, inside and outside of the Gimp, eg in nautilus. Already the 'alias name', present on the list, is only changed if you again export the raster brush or pattern. Ie to change the alias name 'is only one way to re-export the resource again.
This fixes the misleading editing on un-editable things which reverts to the old name on confirm. Let's call this FIXED, we have tons of other bugs about other aspects of resource management, like saving, deleting, renaming read-only stuff, whatnot. commit 82a27545406480235d874dc91b0d2803cf492905 Author: Michael Natterer <mitch@gimp.org> Date: Wed Nov 16 15:13:08 2016 +0100 Bug 343090 - Most brushes and all patterns appear renameable but aren't Introduce virtual function GimpViewable::is_name_editable() and class member "gboolean name_editable" for the default value. Default to FALSE and only return TRUE if the name can actually be edited by the user. When attemting an edit, check the new API and beep instead of starting the edit. app/core/gimpbuffer.c | 1 + app/core/gimpdata.c | 36 ++++++++++++++++++++---------- app/core/gimpitem.c | 2 ++ app/core/gimpsettings.c | 9 +++++--- app/core/gimptemplate.c | 1 + app/core/gimpviewable.c | 23 +++++++++++++++++++ app/core/gimpviewable.h | 6 +++++ app/widgets/gimpcontainertreeview.c | 44 +++++++++++++++++++++++++++++-------- 8 files changed, 98 insertions(+), 24 deletions(-)