Bug 342672 - list returned by gconf_client_all_dirs/entries should be freed
list returned by gconf_client_all_dirs/entries should be freed
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-05-23 08:33 UTC by Paolo Borelli
Modified: 2007-02-03 14:22 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.70 KB, patch)
2006-05-23 08:35 UTC, Paolo Borelli 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Paolo Borelli 2006-05-23 08:33:15 UTC 
Another leak found by code inspection: gconf_client_all_dirs/entries return a list of newly allocated objects, both the object and the string itself need to be freed.
Comment 1 Paolo Borelli 2006-05-23 08:35:49 UTC 
Created attachment 66041 [details] [review]
patch

the patch plugs the above mentioned leak and cleans up some minor bits and other problems (null-check some pointers before dereferencing etc).

Once again the patch is fairly trivial but not tested (as I said I am doing some random code review and cannot run a self compiled settings-daemon at the moment)
Comment 2 Jens Granseuer 2007-01-30 17:44:05 UTC 
Looks good, please apply.
Comment 3 Jens Granseuer 2007-02-03 14:22:56 UTC 
2007-02-03  Jens Granseuer  <jensgr@gmx.net>

        Patch by: Paolo Borelli <pborelli@katamail.com>

        * gnome-settings-keybindings.c: (get_screens_list),
        (screen_exec_display_string), (entry_get_string),
        (bindings_get_entry), (gnome_settings_keybindings_load): plug some
        memory leaks (fixes bug #342672)
Note You need to log in before you can comment on or make changes to this bug.