GNOME Bugzilla – Bug 342443
Evolution month view should be flipped in RTL locale
Last modified: 2013-04-07 01:20:27 UTC
e-calendar-item doesn't flip calendars and days in calendars in RTL locale.
Created attachment 65912 [details] [review] patch for evolution version 2.2.3
Created attachment 65916 [details] [review] and the patch to change the icon of next/prev buttons of e-calendar object
Adding srini in CC list.
i'm going to add an updated patch against current CVS head. i am also going to add two screenshots to understand for non-RTL users what this is about. let's get this into HEAD, and if possible also into 2.6 (the latter has to be decided by somebody who knows if this will break anything). patch works fine for me, as far as i can tell.
Created attachment 67200 [details] calendar view before applying the patch i started evolution 2.7.2.1 with LANG=fa_IR.utf8
Created attachment 67201 [details] calendar view after applying the patch
Created attachment 67202 [details] [review] updated patch against cvs head works for me (TM), as far as i can tell.
setting status of the former to patches to obsolete.
Thanks Andre. Patching these files, i noticed that calendar magic numbers have DEFINEd, but you can see 7, etc in the code yet. I didn't want to change the code more, but it's good to fix them in HEAD.
behnam, can i ask you to please file another bug about the magic numbers explaining this for people not running an RTL locale? thanks a lot in advance.
I reported the magic numbers issue and I'm going to FIX it for the next release. Would you please commit this one for 2.16?
The patch looks ok. Pressing previous and next buttons chooses wrong dates in the date navigator which should be fixed.
so, what to do here? chen, commit the patch and leaving this bug open until the button issue is also fixed? behnam, are you going to provide another complete patch, or a second patch only for the button thingy? common, i want to have this for 2.8.
oookay... behnam, please go ahead and commit the patch. committing this is already a remarkable improval for RTL users. please do not close this bug report though, as we still have to work out the buttons.
(In reply to comment #14) > oookay... > behnam, please go ahead and commit the patch. committing this is already a > remarkable improval for RTL users. Behnam is away for a week... > please do not close this bug report though, as we still have to work out the > buttons. >
behdad, if you tell me his preferred email address used for changelog entries (i actually prefer using the name of the person that wrote the code and only add a comment that i have committed it on behalf of him), i can commit it for him. or feel free yourself, because i do want this fixed for evolution 2.8.
Thanks Andre. Hi signs his gucharmap commits with <behnam@zwnj.org>, although @gnome.org works too. I don't have an evo checkout currently. I would have committed it otherwise. Thanks :).
heh, *we* have to say thanks here, especially for the patience. patch committed to CVS HEAD, will be included in evolution 2.8.0: http://cvs.gnome.org/viewcvs/evolution/widgets/misc/e-calendar.c?r1=1.29&r2=1.30 http://cvs.gnome.org/viewcvs/evolution/widgets/misc/e-calendar-item.c?r1=1.51&r2=1.52 not closing this because of the button issue.
Building from CVS, I noticed the object is not used anymore. But there's something similar in the menu View -> Select Date, which I'm not sure that it's the same widget. I think it's not good to remove it from Day and Week* views. Current sidebar for Day and Week* views has Tasks and Memos, but in a Calendar application, selecting a day is one of the most important ones.
"the object"?
The date selection object on the sidebar of Day and Week* views. The Calendar's Day view doesn't look like attachment 67200 [details] anymore.
With respect to the buttons, it selects right dates for me (in week view for example), only the first (most right) is previous button, and the second (most left) is next button. The icons on these buttons are also correct. Maybe it get fixed somehow? Or is the issue the order of the buttons on the toolbar?
yes, the order. this is an RTL bug.
Bumping version to a stable release.
Created attachment 114281 [details] calendar month view - days header is misaligned On hebrew locale and as you can see in my screenshot also in Arabic locale (ar_DZ.UTF-8) the days header is aligned to the left, making it very hard to follow the dates.
Does the clock applet use a different widget? I see the in evolution calendar it looks just fine.
Yair, thanks for reporting, but please do not steal this bug, rather enter new one, against gtk+, because the gnome-panel uses gtk_calendar_new, so there should be done some fix.
Wondering what is left to close this ticket...?
Well, no answer. Closing.