After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342186 - Loading instruments doesn't affect project dirty flag
Loading instruments doesn't affect project dirty flag
Status: RESOLVED FIXED
Product: beast
Classification: Other
Component: beast-gtk
SVN trunk
Other Linux
: Normal minor
: ---
Assigned To: Beast Maintainers
Beast Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-17 22:21 UTC by Stefan Westerfeld
Modified: 2006-05-31 01:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Stefan Westerfeld 2006-05-17 22:21:51 UTC 
Loading instruments or effects into a project via "Synthesizer/Load Instrument..." or "Synthesizer/Load Effect..." doesn't affect the project dirty flag (that is "File/Save" stays greyed out). However, I think it should affect it.
Comment 1 Tim Janik 2006-05-17 22:49:55 UTC 
can you provide reasoning for why this is necessary?
actuall data loss is highly unlikely because any action to use the newly loaded instrument/effect or to modify it shall toggle the dirty flag.
Comment 2 Stefan Westerfeld 2006-05-17 23:01:18 UTC 
I just noticed it because I tend to use "Save" a lot these days, due to #340437 (and I was confused that I couldn't save after adding instruments), so I thought I'd report it.

Fixing the bug would at least make things more consistent - "Project/New Song" or "Project/Add Custom Synthesizer" for instance do affect the project dirty state, although by your argumentation, actual data loss is equally unlikely.

But its not "necessary" to fix it because you can always reload the instruments  if a crash occured, or use "Save As".
Comment 3 Tim Janik 2006-05-31 01:10:04 UTC 
Wed May 31 03:02:36 2006  Tim Janik  <timj@gtk.org>

        * beast-gtk/bstbseutils.[hc]: added preserve_non_dirty flag to
        bst_project_restore_from_file(), adapted callers.