After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341894 - Consistent name for home
Consistent name for home
Product: nautilus
Classification: Core
Component: [obsolete] Sidebar Panel: Tree
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Reported: 2006-05-15 20:27 UTC by Josselin Mouette
Modified: 2012-08-02 03:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

display name change for home folder (6.32 KB, patch)
2010-07-20 04:07 UTC, gachen
needs-work Details | Review
patch based on previou patch (4.21 KB, patch)
2010-07-29 09:46 UTC, gachen
none Details | Review
Display name change for home folder (4.30 KB, patch)
2011-01-05 14:00 UTC, Marcus Husar
committed Details | Review
Display name change of home folder in history and bookmarks (1.53 KB, patch)
2011-01-05 14:04 UTC, Marcus Husar
reviewed Details | Review

Description Josselin Mouette 2006-05-15 20:27:47 UTC
[ forwarded from ]

  The name for the users home folder should be the same as on the desktop. 
  If a user has altered the home_icon_name via gconf the treeview in 
  nautilus tells it still home folder. And in nautilus menu/go/ it's just 
  home. After i accessed it the history in nautilus-menu/go/ tells it like 
  the real folder name. The same applies for gnome-menu/places, but this 
  may be not related to nautilus, i don't know it. 

  All this should be more consistant. This makes it easier for 
  unexperienced users which have problems with all this different names 
  for the same thing.

The bug is still present in 2.14. In fact that makes two places where home_icon_name isn't used: the panel and the treeview.
Comment 1 Christian Kirbach 2006-05-19 15:41:23 UTC
SOunds like inconsistency, however especially unexperienced users will almost certainly not fiddle around with gconf.
Comment 2 Carsten Luedtke 2006-06-11 19:14:46 UTC
One doesn't need to use gconf. Nautilus offers also to rename this from the right-click menu directly on the desktop. And as a site note, i rename my home_icon_name since the german translation is rather ugly and long (Persönlicher Ordner / personal folder). 

And for windows converters it maybe usefull to rename it to what windows would have called it. This maybe not an argument to a knowledged user, but there are enough dumb users out there - and i wish i could convert my mother to gnome, cause i love it, but with such inconsistencies it's rather harmful to me.
Comment 3 Paul Bolle 2008-11-19 23:54:39 UTC
0) consistency
In the 2.24.1 desktop for folders with a home icon added (or windows with a small home icon) three names are used out of the box:
- Home Folder
- $USER's Home

1) renaming
If one changes the name of "$USER's Home" the panel's "Places > Home Folder" will become "Places > $NEW". If one reverts that change it will become "Places > $USER's Home". Only after removing .gconf/apps/nautilus/desktop/%gconf.xml will it be once again the original "Places > Home Folder". (The Places menu in folder windows seem unaffected by all this.)
Comment 4 Allan Day 2010-06-07 19:40:49 UTC
The Tree side pane uses 'Home Folder', as does the Go menu. The Places side pane and the path bar use the user name. They should all just use 'Home'.
Comment 5 Allan Day 2010-06-11 17:01:52 UTC
I've just noticed that the home icon on the desktop is named "<user name>'s home" that should also be called the same as everything else: "Home".
Comment 6 Marcus Carlson 2010-07-11 19:22:33 UTC
When browsing /home/, should my home folder be named "Home" as well?
Comment 7 Vish 2010-07-11 20:10:51 UTC
(In reply to comment #6)
> When browsing /home/, should my home folder be named "Home" as well?

For reference:
Comment 8 Allan Day 2010-07-12 08:17:03 UTC
(In reply to comment #6)
> When browsing /home/, should my home folder be named "Home" as well?

No. The various names that have been used for this location in the UI have always been a mask. This bug isn't proposing a radical change from that - just a minor cleanup of terminology.
Comment 9 gachen 2010-07-20 04:07:43 UTC
Created attachment 166190 [details] [review]
display name change for home folder
Comment 10 Marcus Carlson 2010-07-20 19:56:42 UTC
Review of attachment 166190 [details] [review]:

Just a quick review, didn't try it out.

::: src/file-manager/fm-directory-view.c
@@ +7467,3 @@
 				G_CALLBACK (action_move_to_next_pane_callback) },
   /* name, stock id, label */  {FM_ACTION_COPY_TO_HOME, NAUTILUS_ICON_HOME,
+				N_("Home"), NULL,

Why is the mnemonic removed here?

::: src/nautilus-history-sidebar.c
@@ +85,3 @@
+char * nautilus_history_sepcial_displayname		(char * uri);

Typo. sepcial -> special.

@@ +94,3 @@
+	ret = NULL;
+	home_uri = nautilus_get_home_directory_uri();

Missing space. Should be:
home_uri = nautilus_get_home_directory_uri ();

@@ +127,3 @@
+		uri = nautilus_bookmark_get_uri (bookmark);
+		name = nautilus_history_uri_get_sepcial_displayname (uri);
+		if (NULL == name) {

I think we usually do (name == NULL)
Comment 11 gachen 2010-07-29 09:46:07 UTC
Created attachment 166761 [details] [review]
patch based on previou patch
Comment 12 Marcus Carlson 2010-07-30 22:19:27 UTC
gachen, thanks for your work but could you create a patch that's not based on a previous patch? It gets really hard to see what changes has been made to the original code with patched patches ;)

Other than that, here's a few small code style things;

> }
>+static char *
>+get_special_displayname_for_uri (const char *uri)

Try to keep one new line between functions.

>+	if (0 == g_strcmp0 (uri,(const char *)home_uri)){

Missing spaces and should probably be the other way around, like this:
if (g_strcmp0 (uri, (const char *)home_uri) == 0) {

>+	return ret;
> char *
> nautilus_bookmark_get_name (NautilusBookmark *bookmark)

Missing new line between functions.

>+	if (name)
>+		return name;
>+	else
>+		return g_strdup (bookmark->details->name);

Missing braces.

>-		uri = nautilus_bookmark_get_uri (bookmark);

Is uri still defined?

Note: I've not tested the patch and cannot comment if this is right - that's something the real devs has to answer :)
Comment 13 Vish 2010-08-17 05:12:56 UTC
(In reply to comment #11)
> Created an attachment (id=166761) [details] [review]
> patch based on previou patch

gachen, Could you update your patch? [We have User Interface Freeze next week, in Ubuntu, we would like to fix this before that.]
Comment 14 Paul Bolle 2010-08-17 07:54:32 UTC
0)'s interface for submitting patches isn't that great. For example, it's easy to not add the (proposed) commit message to the text of the comment that adds the patch. That forces one to go back and forth between the comments and individual patches. Annoying.

(In reply to comment #9)
> Created an attachment (id=166190) [details] [review]
> display name change for home folder

So this is:
    [PATCH] display name change for home folder

    change the display name of home folder to "Home" in history/places/tree
    sidepanes, "Go" menu, and desktop icons
    fix of error

(In reply to comment #11)
> Created an attachment (id=166761) [details] [review]
> patch based on previous patch

And this is:

    [PATCH] display name change , "Home Folder" to "Home"

1) The patch added to comment #11 needs a better commit message.

2) Do these patches also address (some or all of) the occurrences of "$USER's Home" and "$USER"?
Comment 15 Marcus Husar 2011-01-05 14:00:48 UTC
Created attachment 177565 [details] [review]
Display name change for home folder

Change the display name of the home folder to "Home" in places/tree sidepanes, "Go" menu, and desktop icons.
Comment 16 Marcus Husar 2011-01-05 14:04:56 UTC
Created attachment 177567 [details] [review]
Display name change of home folder in history and bookmarks

Change the display name of home folder in history list inside the
"Go" menu, and in bookmarks.
Comment 17 Marcus Husar 2011-01-05 14:16:19 UTC
The patches above in comment #15 and comment #16 should solve this problem properly.

The patch in comment #15 addresses all occurrences of  "$USER's Home", "Home Folder" and "$USER". The patch in comment #16 changes the display name in the history list in the "Go" menu, and  in bookmarks (in the side pane and in the "Bookmarks" menu).
Comment 18 Vish 2011-01-06 16:31:32 UTC
(In reply to comment #17)
> The patches above in comment #15 and comment #16 should solve this problem
> properly.

Nice work Marcus Husar. Nautilus devs usually do not focus on bug comments.(since it often gets too noisy here on bugzilla).

The way to get their attention quicker is to send a mail to nautilus mailing list > .
Just send a mail requesting review of the patch.
Comment 19 Cosimo Cecchi 2011-01-10 09:20:21 UTC
Hi Marcus, thank you very much for the patches!
I pushed to master the first patch and a slightly modified version of the second, together with some more naming fixes for the places sidebar.

Closing as FIXED.
Comment 20 Stefan Wagner 2012-08-02 03:27:06 UTC
That doesn't look reasonable to me, please see my comment here: