GNOME Bugzilla – Bug 341355
Goom visualization in totem-gstreamer is very low-res
Last modified: 2008-02-27 23:44:33 UTC
Please describe the problem: When I use totem-xine, the goom resolution can be adjusted by choosing visualization size. However, in totem-gstreamer, it is always lo-res and looks like poop. Steps to reproduce: 1. Crank up totem-gstreamer 2. Turn on goom 3. Set it to high res Actual results: stays as lo-res Expected results: go to hi-res Does this happen every time? yep Other information: Only if necessary :-)
I repro'ed this bug on FC 5 as well. I love Goom and I'm trying to use Gstreamer and so I hope this bug get fixed before too long. :-)
This bug needs to be assigned to gstreamer-plugins-good, but I can't move it because I don't have sufficient permission. Can someone do this?
Is there anyone with the requisite permissions out there to confirm this bug and assign it to gstreamer-plugins-good?
Are you sure it's a GStreamer plugins problem? Looks to me like it's a GStreamer backend problem.
I'm not really sure because I don't know what a gstreamer backend is, but I did look through gstreamer-plugins-good and saw that it had a goom implementation with lots of references to 320x200 in the code and assumed that the problem is there. It could also be in the totem code which calls gstreamer, but so as long as someone else looks at it so this bug isn't mis-assigned by me to languish in the wrong place, I'm happy. The fact that goom in totem-gstreamer is *only* 320x200 on Ubuntu and FC5 should really be fixed. The OSS community has too much pride for such a bug, I know.
Could you start totem from the command line like this: $ export GST_DEBUG_NO_COLOR=1 $ export GST_DEBUG=totem:5,goom:5 $ totem 2> dbg.log and then open some audio file, play it and change the visualisation size? (no need to play the whole file, just a few seconds here and there should do) After that please $ gzip dbg.log and attach the dbg.log.gz file to this bug report. Also, could you tell us the output of: $ gst-inspect-0.10 goom | grep Version The references to 320/200/240/whatever in the goom code are probably the default size to fixate to when no size is specified explicitly. Changing the size seems to work fine for me, and my CPU usage also goes up as I increase the size of the visualisation, so I can't tell whether your problems are caused by something in the backend or in gst-plugins-good right now. The log might shed some light.
Created attachment 67030 [details] logfile from totem
The goom version is 10.3--standard Ubuntu. I changed the zoom a few times back and forth from large to normal to extra large. I never set it to small.
The log file is unusable, but I think I fixed it with this commit in CVS HEAD. Please test. 2006-11-27 Bastien Nocera <hadess@hadess.net> * src/backend/bacon-video-widget-gst-0.10.c: (bacon_video_widget_realize), (size_changed_cb), (get_visualization_size): * src/backend/bacon-video-widget-xine.c: (bacon_video_widget_finalize), (size_changed_cb), (bacon_video_widget_set_visuals_quality): Hopefully fix xine-lib build, Make the GStreamer backend respect widescreen output for visualisations
Great to hear!!! I do not know how to test CVS, however. If someone doesn't beat me to it, I will test this bug when I start running betas of Feisty Fawn...
appears to be working under ubuntu feisty *poking keith curtis to verify*
I can't really tell if it is hires. I'm including 3 attachments for comparison Two of gstreamer, one at low-res, one at hi-res, and one of xine's gstreamer at hi-res. To me, the totem-gstreamer still looks very bad compared to xine's gstreamer. I think something is wrong. Note that the pictures aren't of the same stuff, but it is hard to do because of the tremendous variability of goom.
Created attachment 88872 [details] Gstreamer's goom at "very large" resolution
Created attachment 88873 [details] lo-res gstreamer's goom
Created attachment 88874 [details] Xine's Goom at hi-res. It looks kick ass!
Furthermore, In Xine, when I choose the various Goom sizes, and then hit 1 to resize to 1:1 sizing, the window changes size. In Gstreamer, the 1:1 size is always very small.
There's an updated goom which sucks less in gst-plugins-good CVS (see bug 515073). I fixed the problem with the resizing when visuals are on. 2008-02-27 Bastien Nocera <hadess@hadess.net> * src/backend/bacon-video-widget-gst-0.10.c (bacon_video_widget_set_scale_ratio): When a visualisation is playing, and we're being asked to resize the window to a scale, use the viz size to resize the window (Closes: #341355) * src/totem.c (window_state_event_cb): Remove debug
Great to see this happen!!