After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341146 - reorder lines in configure.in for a better display
reorder lines in configure.in for a better display
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-09 15:40 UTC by Ludovic Rousseau
Modified: 2013-10-06 05:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reorder message in configure.ac (1.14 KB, patch)
2013-09-28 23:30 UTC, Timothy Arceri
committed Details | Review

Description Ludovic Rousseau 2006-05-09 15:40:40 UTC
The gtk+ ./configure script displays:
[...]
checking X11/extensions/XShm.h... yes
checking for Xinerama support on XFree86... checking for XineramaQueryExtension in -lXinerama... no
no
checking for XRRUpdateConfiguration in -lXrandr... no
[...]

You can see a "no" alone on its own line. This is because we have two checks imbricated: checking for XineramaQueryExtension is inside checking for Xinerama.

With the patch I propose we have:
[...]
checking X11/extensions/XShm.h... yes
checking for XineramaQueryExtension in -lXinerama... no
checking for Xinerama support on XFree86... no
checking for XRRUpdateConfiguration in -lXrandr... no
[...]

The patch is very simple and just move the call to AC_MSG_CHECKING() a but later in the script.

Regards,

--- gtk+/configure.in	2006-05-01 22:26:42.000000000 +0000
+++ gtk+.new/configure.in	2006-05-09 15:26:31.000000000 +0000
@@ -1247,14 +1247,14 @@
   case "$host" in
       *-*-solaris*)
           # Check for solaris
-	  AC_MSG_CHECKING(for Xinerama support on Solaris)
-	  
 	  have_solaris_xinerama=false
 	  AC_CHECK_FUNC(XineramaGetInfo,
 	      [AC_CHECK_HEADER(X11/extensions/xinerama.h,
   		  [have_solaris_xinerama=true], :,
 		  [#include <X11/Xlib.h>])])
 		
+	  AC_MSG_CHECKING(for Xinerama support on Solaris)
+	  
           if $have_solaris_xinerama ; then
             AC_DEFINE(HAVE_SOLARIS_XINERAMA)
 	    AC_DEFINE(HAVE_XINERAMA) 
@@ -1265,8 +1265,6 @@
           ;;
       *)
 	  # Check for XFree
-          AC_MSG_CHECKING(for Xinerama support on XFree86)
-	  
           have_xfree_xinerama=false
           if $PKG_CONFIG --exists xinerama ; then
              have_xfree_xinerama=true
@@ -1279,6 +1277,8 @@
                       [#include <X11/Xlib.h>])])
           fi
 
+          AC_MSG_CHECKING(for Xinerama support on XFree86)
+	  
           if $have_xfree_xinerama ; then
             AC_DEFINE(HAVE_XFREE_XINERAMA)
 	    AC_DEFINE(HAVE_XINERAMA)
Comment 1 Timothy Arceri 2013-09-28 23:30:17 UTC
Created attachment 255993 [details] [review]
Reorder message in configure.ac

The XFree message seems to have been fixed in a different way since this bug was first reported. I've attached an updated patch to move the Solaris message.

Hopefully someone can review and commit it so this bug can finally be closed.
Comment 2 Emmanuele Bassi (:ebassi) 2013-10-02 11:45:49 UTC
Review of attachment 255993 [details] [review]:

sure.