After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340962 - gnome-terminal should use gtk2.9 Notebook DND support
gnome-terminal should use gtk2.9 Notebook DND support
Status: RESOLVED DUPLICATE of bug 353775
Product: gnome-terminal
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-07 22:02 UTC by Mart Raudsepp
Modified: 2006-09-09 16:26 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Initial patch that tries to sync the tab reordering to chpe's gtk2.9 based new code in epiphany (71.58 KB, patch)
2006-05-08 12:47 UTC, Mart Raudsepp 		needs-work Details | Review

Description Mart Raudsepp 2006-05-07 22:02:32 UTC 
gnome-terminal should re-use new gtk2.9 Notebook DND support instead of rolling
its own.
This gives us more code re-use, and... animations, yay!
I intend to work on this, but I don't know when I get the time to, so if anyone
else is wanting to work on this, just let me/us know as a comment.
Comment 1 Behdad Esfahbod 2006-05-07 22:03:52 UTC 
That would be rad!
Comment 2 Mart Raudsepp 2006-05-08 12:47:04 UTC 
Created attachment 65020 [details] [review]
Initial patch that tries to sync the tab reordering to chpe's gtk2.9 based new code in epiphany

First cut at implementing this.
Basically re-syncs the tab reordering code with changes in epiphany towards gtk2.9 notebook DND.
Looses detaching support, which I'll need to still add.
Has weird window growing when switching to first tab that I haven't looked at yet at all.

Putting current changes up for interested parties, as I'm done for today with this.
Comment 3 Behdad Esfahbod 2006-05-08 17:47:54 UTC 
The bug with resizing when switching tabs has been there for a few weeks now.  It's not your fault :).
Comment 4 Mart Raudsepp 2006-07-03 11:53:38 UTC 
After some thinking I'm not sure we are ready for converting to the new notebook DND API as of yet, as detaching will see a regression - can only detach by dragging onto the desktop, not anywhere else above other app windows.
Or should we still convert over at this point?
A pointer to the relevant DND bug (default actions?) would be welcomed as well.
Comment 5 Mariano Suárez-Alvarez 2006-09-09 16:26:34 UTC 
Unhistorically dup'ing

*** This bug has been marked as a duplicate of 353775 ***