GNOME Bugzilla – Bug 340742
No history copied over when opening link in new tab/win using context menu
Last modified: 2006-06-08 19:30:27 UTC
In a tab or window with history (where you can "go back"), open a link in a new tab by selecting "Open in new tab" from the context menu of a link. The resulting new tab has no history associated (cannot "go back"). The same happpens when opening in a new window. On the contrary, opening a link with a middle mouse click or Ctrl+left-click results in the new tab having a history. So the functionality is already there, a simple patch follows that seems to fix this little inconsistency.
Created attachment 64860 [details] [review] Simple fix attempt Just copied over the call to ephy_embed_shistory_copy () from ephy-tab.c:open_link_in_new () to ephy-shell.c:ephy_shell_new_tab_full (). Seems to fix the issue (for both new tabs and windows). Applies cleanly to 2.14.1 and CVS HEAD.
Thanks for the patch! Phil: was there a reason you didn't add it in ephy-shell originally when you added the session history copying? (I can't remember.)
No, I probably just forgot to handle this case. Patch looks fine.
Fixed in HEAD. 2006-06-08 Wouter Bolsterlee <uws+gnome@xs4all.nl> * src/ephy-shell.c: (ephy_shell_new_tab_full): copy history over when opening link in new tab/win using context menu. Fixes bug #340742, patch by René Stadler. Chpe, can you apply this to gnome-2-14 if you decide it should go there too?
Ok to commit to gnome-2-14 .