After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340507 - f-spot crashed when adding tag to offline image (thumbnail)
f-spot crashed when adding tag to offline image (thumbnail)
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Tags
CVS
Other All
: Normal critical
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-03 10:35 UTC by Chris Kühl
Modified: 2006-05-24 03:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds an check for the file before writing metadata (289 bytes, patch)
2006-05-03 15:11 UTC, Chris Kühl
none Details | Review

Description Chris Kühl 2006-05-03 10:35:47 UTC
Steps to reproduce:
1. import an image from a removable device
2. disconnect that device
3. drag tag onto thumbnail
4. Exception dialog appears

How often: always

Stack trace:
An unhandled exception was thrown: Could not find uri
"file:///media/usbdisk/sharedfiles/photos/sink/DSCN1467.JPG".

in <0x00962> Gnome.Vfs.VfsStream:.ctor (System.String text_uri, FileMode mode,
Boolean async)
in <0x00012> Gnome.Vfs.VfsStream:.ctor (System.String uri, FileMode mode)
in (wrapper remoting-invoke-with-check) Gnome.Vfs.VfsStream:.ctor
(string,System.IO.FileMode)
in <0x00045> FSpot.ImageFile:Open ()
in <0x00028> FSpot.JpegFile:get_Header ()
in <0x00025> FSpot.JpegFile:get_ExifData ()
in <0x00022> FSpot.JpegFile:SetDescription (System.String value)
in <0x000b0> Photo:WriteMetadataToImage ()
in <0x0007f> MainWindow:HandleDbItemsChanged (System.Object sender,
.DbItemEventArgs args)
in (wrapper delegate-invoke)
System.MulticastDelegate:invoke_void_object_DbItemEventArgs (object,DbItemEventArgs)
in <0x0001d> DbStore:EmitChanged (.DbItem[] items, .DbItemEventArgs args)
in <0x0008c> PhotoStore:Commit (.DbItem[] items, .DbItemEventArgs args)
in <0x0003f> PhotoStore:Commit (.DbItem item)
in <0x00026> FSpot.PhotoQuery:Commit (Int32 index)
in <0x0007b> MainWindow:AddTagExtended (Int32 num, .Tag[] tags)
in <0x00052> MainWindow:AttachTags (.Tag[] tags, System.Int32[] ids)
in <0x001d1> MainWindow:HandleIconViewDragDataReceived (System.Object sender,
Gtk.DragDataReceivedArgs args)
in (wrapper delegate-invoke)
System.MulticastDelegate:invoke_void_object_DragDataReceivedArgs
(object,Gtk.DragDataReceivedArgs)
in <0x00264> Gtk.Widget:DragDataReceivedSignalCallback (IntPtr arg0, IntPtr
arg1, Int32 arg2, Int32 arg3, IntPtr arg4, UInt32 arg5, UInt32 arg6, IntPtr gch)
in (wrapper native-to-managed) Gtk.Widget:DragDataReceivedSignalCallback
(intptr,intptr,int,int,intptr,uint,uint,intptr)
in <0x00000> <unknown method>
in (wrapper managed-to-native) Gtk.Application:gtk_main ()
in <0x00007> Gtk.Application:Run ()
in <0x00007> Gnome.Program:Run ()
in <0x005b2> FSpot.Driver:Main (System.String[] args)
.NET Version: 1.1.4322.2032

Assembly Version Information:

FlickrNet (1.1.0.0)
System.Web (1.0.5000.0)
gconf-sharp (2.8.0.0)
pango-sharp (2.8.0.0)
SemWeb (0.5.0.2)
glade-sharp (2.8.0.0)
gtkhtml-sharp (2.8.0.0)
System.Data (1.0.5000.0)
Mono.Data.SqliteClient (1.0.5000.0)
gdk-sharp (2.8.0.0)
Mono.Posix (1.0.5000.0)
gnome-vfs-sharp (2.8.0.0)
dbus-sharp (0.60.0.0)
System (1.0.5000.0)
atk-sharp (2.8.0.0)
gtk-sharp (2.8.0.0)
glib-sharp (2.8.0.0)
gnome-sharp (2.8.0.0)
f-spot (0.0.0.0)
mscorlib (1.0.5000.0)

Platform Information: Linux 2.6.15-21-686 i686 unknown GNU/Linux

Disribution Information:

[/etc/debian_version]
testing/unstable

[/etc/lsb-release]
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=6.06
DISTRIB_CODENAME=dapper
DISTRIB_DESCRIPTION="Ubuntu (The Dapper Drake Release) Development Branch"



Other information:
Comment 1 Chris Kühl 2006-05-03 10:44:22 UTC
To clarify, i store my images on the removable device when ever I import. So the first line should read import images onto a removable device.
Comment 2 Chris Kühl 2006-05-03 13:38:59 UTC
I just noticed i had the "Wraite metedata to files" option on in Preferences. When this is not selected f-spot is fine.

Seems like a dialog box informing the user that the metadata can not be saved to the file and asking if she wants to add the tag to the f-spot database only.

Or should f-spot just do everything silently and write the metadata to the file when it is available and otherwise just write to the f-spot db?
Comment 3 Chris Kühl 2006-05-03 15:11:00 UTC
Created attachment 64750 [details] [review]
Adds an check for the file before writing metadata

The patch simply ignores the fact that the metadata wasn't written. This is what happens when you attempt to the Remove tag EVERYTIME. (from what i can tell.)
	
Both probably need to initially remind the user that the data can't be written but provide an option to ignore when the photos aren't online forever.
Comment 4 Bengt Thuree 2006-05-17 07:20:05 UTC
I think there needs to be an indication that tags are waiting to be written to disk (photos), and when you click/select this, you will get another popup window stating "Tags needs to be written for xxxxxx,x,x,x,x,x,x. Please insert the following media(s) ....."

When all tags have been written to disk, the indication should dissapear.
Comment 5 Bengt Thuree 2006-05-17 16:38:31 UTC
Related bug in bug #322805 - import from removable media
Comment 6 Larry Ewing 2006-05-24 03:54:40 UTC
This crash is fixed in CVS