GNOME Bugzilla – Bug 340206
[patch] Little patch for GtkTreeView to draw a focus on current row. (with patch files)
Last modified: 2018-02-10 04:39:40 UTC
Under Windows, rows of list view/tree view which have cursors on them (most often selected) always have focus drawn if the view widgets have input focus. This patch draw a focus rectangle on the row with cursor. (Windows only)
Created attachment 64576 [details] [review] Patch for GtkTreeView
I don't think it's a good idea to unconditionally change the appearance on Windows like that. This should be something that happens only if the ms-windows theme is used, shouldn't it? And the ifdef should check GDK_WINDOWING_WIN32, not G_OS_WIN32 (yeah, in practise those are equivalent, at least currently).
Is it possible to add a new style property for this, and make default value to FALSE? Then we can set it to TRUE in Wimp engine?
Created attachment 66693 [details] [review] A new patch adding a style property called "full-row-focus" instead of changing things unconditionally. Since Tor Lillqvist says this shouldn't be changed unconditionally, I add a style property for it. Here is a new patch adding a style property called "full-row-focus" instead of changing things unconditionally. If the value of this style property is TRUE, draw the focus rectangle for the full selected row, when the tree view has focus. We can turn on this property in Wimp theme engine to mimic the behavior of native Windows applications.
The indentation for that if statement looks a little odd --- GTK uses spaces rather than hard tabs, which seem to have made an appearance in some lines. It might be an idea to model the documentation for this new property after that of "rules-hint"; i.e. change the description to "Set a hint to the theme engine to draw a focus rectangle for a full row", as theme engines might ignore this property, while the ms-windows one will probably use it anyway.
I don't think I would like a patch like this in GtkTreeView. I also observed that the Wimp theme binds the left/right arrows keys to expand/collapse; this is very bad as it breaks key navigation in certain applications (see #465516 and related). The appearance of the focus rectangle is vital for proper keyboard navigation.
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue for it.