After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339998 - Gnome button order
Gnome button order
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other All
: Normal normal
: 0.10.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 337894
 
 
Reported: 2006-04-28 08:11 UTC by Alan Horkan
Modified: 2006-05-16 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alan Horkan 2006-04-28 08:11:39 UTC
sorry if this has been fixed already but 0.9.9.2 is the best i can manage to get running for the moment

The "render project" dialog uses the wrong button order.  The action button (render in this case) should be on the right.  

Rather than using the button label Choose File I would recommed "Browse..." which isn't any better but is consistent with what everyone else does.  
Rather than having "Settings: [Settings]" you might want to consider having buttons like More... or perhaps Details..., I'm not sure yet what would be best for Pitivi.  
when you do hit that settings button the export settings dialog it bring up uses the wrong button order for Ok Cancel.  This dialog seems to be largely a repeat of the New Project dialog, and the duplication might indicate a design problem since it can be confusing to present users with two different ways of achieving the same task (and it seems like not all users will know in advance what final settings they will need).  


You might want to consider implementing the alternative button order option to keep KDE users happy but that is another bug for another day.
Comment 1 Edward Hervey 2006-04-28 08:26:26 UTC
(In reply to comment #0)
> sorry if this has been fixed already but 0.9.9.2 is the best i can manage to
> get running for the moment

  This issues are still present in latest release.

> 
> The "render project" dialog uses the wrong button order.  The action button
> (render in this case) should be on the right.  
> 
> Rather than using the button label Choose File I would recommed "Browse..."
> which isn't any better but is consistent with what everyone else does.  
> Rather than having "Settings: [Settings]" you might want to consider having
> buttons like More... or perhaps Details..., I'm not sure yet what would be best
> for Pitivi.  
> when you do hit that settings button the export settings dialog it bring up
> uses the wrong button order for Ok Cancel.  This dialog seems to be largely a
> repeat of the New Project dialog, and the duplication might indicate a design
> problem since it can be confusing to present users with two different ways of
> achieving the same task (and it seems like not all users will know in advance
> what final settings they will need).  
> 

  Marking this bug as a blocker for the HIG Tracker bug.

> 
> You might want to consider implementing the alternative button order option to
> keep KDE users happy but that is another bug for another day.
> 

  For KDE users, there's a clean separation in PiTiVi between logic and UI, so that it would be *rather* easy to create a qt/kde UI. In fact I proposed that for a GStreamer/KDE summer of code idea.
Comment 2 Alan Horkan 2006-04-29 16:12:46 UTC
(In reply to comment #1)

> > You might want to consider implementing the alternative button order option to
> > keep KDE users happy but that is another bug for another day.

>   For KDE users, there's a clean separation in PiTiVi between logic and UI, so
> that it would be *rather* easy to create a qt/kde UI. In fact I proposed that
> for a GStreamer/KDE summer of code idea.

It would be great to see more Qt/Gstreamer projects but in the long run hopefully better themes, efforts like the Portland project (backed by OSDL) and features like alternative button order in GTK will help make it so only developers need worry about the underlying toolkit.  



Comment 3 Edward Hervey 2006-05-16 16:28:53 UTC
I fixed the button order in all available dialog boxes.

2006-05-16  Edward Hervey  <edward@fluendo.com>

	* pitivi/bin.py:
	Fixed recording for tee -> identity conversion/hack.
	We remove audio/video sink when encoding and put them back when finished.
	* pitivi/playground.py:
	added debug for position signal emission.
	* pitivi/ui/complextimeline.py:
	don't send a negative frame value to toplayer's timelinePositionChanged
	* pitivi/ui/encodingdialog.glade:
	Better order for buttons.
	Cancel button becomes close button.
	* pitivi/ui/viewer.py:
	Grey-out (set_sensitive()) the main window when the encoding dialog is showing.
	Lots of fixes with the EncodingDialog:
	_ Close button becomes cancel when encoding
	_ Show Time Left in progressbar
	_ Use playground's 'position' signal