GNOME Bugzilla – Bug 339729
play sound effect when ripping and burning are done
Last modified: 2018-05-24 11:33:07 UTC
Might be nice to play a short sound effect when ripping and burning are done. I think I saw this in iTunes on Windows. It is helpful when you start the process and walk away to do something else so you don't have to keep checking back.
I wonder if any of the standard sounds would be appropriate.
This would be easy using libcanberra-gtk now. See bug 542693.
*** Bug 576237 has been marked as a duplicate of this bug. ***
Created attachment 133776 [details] [review] Play sound effect when ripping & burning are done Add an optional dependency on libcanberra-gtk. Play a sound effect when ripping is complete, and when burning through libnautilus is complete.
Created attachment 133777 [details] [review] Play sound effect when ripping & burning are done Add an optional dependency on libcanberra-gtk. Play a sound effect when ripping is complete, and when burning through libnautilus is complete.
@@ -1934,6 +1938,12 @@ rb_shell_transfer_progress_cb (RBRemovableMediaManager *mgr, g_free (s); } else { rb_statusbar_set_progress (shell->priv->statusbar, -1, NULL); +#ifdef HAVE_LIBCANBERRA_GTK + ca_context_play (ca_gtk_context_get (), 0, + CA_PROP_EVENT_ID, "complete-media-rip", + CA_PROP_EVENT_DESCRIPTION, _("Extraction completed"), + NULL); +#endif } } This is going to happen when any transfer finishes, not just CD ripping. complete-media-rip probably isn't appropriate for transfers to/from ipods or other devices. There isn't really a way to distinguish between them at that point, though.
So, I guess what we need to do is have the target source add a transfer-progress signal handler (in rb-library-source for the library, rb-removable-media-source for devices) that plays the sound when the transfer is finished, then disconnects itself. The library implementation could look at the source URIs to decide what event ID to use (complete-media-rip for cdda://, something else for other schemes), maybe.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/181.