GNOME Bugzilla – Bug 339366
[playbin] hangs if suburi file type cannot be determined
Last modified: 2006-12-11 10:51:31 UTC
(I do not speak well English :) I have Fedora Core 5 installed in my PC (totem is update): if I have a text file (txt) in same folder of the average file and these have the same name (for example, sound.mp3 and sound.txt), Totem Crashes. I have lame (mp3 plugin) because i update the gstreamer 0.10 from http://gstreamer.freedesktop.org/pkg/fedora/5/0.10/i386/.
Thanks for the bug report. Without a stack trace from the crash it's very hard to determine what caused it. Can you provide us with one? Please see http://live.gnome.org/GettingTraces for more information on how to do so.
I believe this bug is fixed in both totem (don't check for corresponding subtitle files for audio-only files) and in gst-plugins-base CVS (error out instead of crashing when a subtitle file is added for an audio-only file).
*** Bug 339492 has been marked as a duplicate of this bug. ***
Ah, but this bug hits for non audio-only files as well. It happens for any type of file, according to my tests. It's entirely possible that someone might have filename.avi or filename.mpg in a directory, and then filename.txt which contains information about the file but isn't a subtitle file. It's a lot less likely with all the other extensions, but .txt is common enough that it may certainly be used by a user for things other than subtitle files. So not checking for subtitle files for audio-only files isn't enough to fix the problem.
Also, with all my tests it's not actually a crash, it's a hang, FWIW.
Well, the devs can probably say if it's not the same bug and reopen the other one, but my gut feeling says that they're the same...
Yeah, these are the same bugs. I was just trying to give a fuller description of what's going on with this one. The original reporter only noticed it for mp3s, but since it happens for video files as well, it's a bigger problem than just not looking for subtitle files on audio-only files. To really fix the problem, it needs to not hang when the putative subtitle file isn't really one.
Not sure what other info is needed, reopening. If it is in deed fixed, please close this.
*** Bug 339942 has been marked as a duplicate of this bug. ***
With current GStreamer-0.10 CVS playbin seems to hang if the media type of the subtitle file is not recognised. More precisely, it hangs in setup_source() at: while (!play_base_bin->subtitle_done) GROUP_WAIT (play_base_bin); Also need to check what happens if: * subtitle stream media type is known but not decodable * subtitle stream media type is known and decodable and audio and/or video
Hang fixed at least for immediate errors: 2006-10-18 Tim-Philipp Müller <tim at centricular dot net> * gst/playback/gstplaybasebin.c: (setup_source): Don't hang forever if the subbin already fails to start up in the state change to PAUSED (#339366). Still need to handle async errors.
Fixed for async errors as well now (and there are no real problems if the suburi file is an audio or video file either): 2006-10-18 Tim-Philipp Müller <tim at centricular dot net> * gst/playback/gstplaybasebin.c: (subbin_startup_sync_msg), (setup_source): Catch async errors when starting up the subtitle bin, so we can stop waiting and continue with the main film instead of hanging forever. Fixes #339366. * tests/check/elements/playbin.c: (playbin_suite): Enable unit test for the above.
*** Bug 364560 has been marked as a duplicate of this bug. ***
*** Bug 323255 has been marked as a duplicate of this bug. ***
*** Bug 381162 has been marked as a duplicate of this bug. ***