Bug 339013 - [videorate] Goes into an infinite loop
[videorate] Goes into an infinite loop
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
:
: 338995 (view as bug list)
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-04-19 12:08 UTC by Edward Hervey
Modified: 2006-04-26 16:44 UTC (History)
4 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix videorate (871 bytes, patch)
2006-04-19 12:09 UTC, Edward Hervey 		accepted-commit_after_freeze Details | Diff | Review
Updated version (1.01 KB, patch)
2006-04-26 15:14 UTC, Edward Hervey 		none Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Edward Hervey 2006-04-19 12:08:06 UTC 
When videorate receives a buffer which is before the previous received buffer, it goes into an infinite loop.

The problem is videorate should discard the incoming buffer if it is before the previous one.

The attach patch solves the issue
Comment 1 Edward Hervey 2006-04-19 12:09:38 UTC 
Created attachment 63860 [details] [review]
Patch to fix videorate

This patch drops incoming buffers that are before previously received buffers.
Comment 2 Wim Taymans 2006-04-21 15:21:51 UTC 
*** Bug 338995 has been marked as a duplicate of this bug. ***
Comment 3 Thomas Vander Stichele 2006-04-22 21:06:08 UTC 
The patch is missing % signs before doing GST_TIME_FORMAT.

why is this a blocker ? obviously something else is going wrong if buffers are sent in the wrong order, and it's not a regression afaict.
Comment 4 Edward Hervey 2006-04-23 07:51:05 UTC 
agreed, it's not a regression but a very critical bug, and it's only caused by an upstream element sending buffers in the wrong order.

BUT, videorate going in an endless loop IS a major bug. It should gracefully handle that situation, not lockup the dataflow, and inform the user (possibly with a GST_MESSAGE_WARNING).
Comment 5 Edward Hervey 2006-04-26 15:14:49 UTC 
Created attachment 64329 [details] [review]
Updated version

I fixed the % issue in the debug string and also incremented the number of dropped buffer.
Comment 6 Thomas Vander Stichele 2006-04-26 16:44:56 UTC 
commited to head
Note You need to log in before you can comment on or make changes to this bug.