After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339000 - totem / qtdemux fails to redirect to relative links in mov files
totem / qtdemux fails to redirect to relative links in mov files
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.4.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-04-19 10:59 UTC by j^
Modified: 2006-05-14 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
propsed patch (1.44 KB, patch)
2006-04-19 13:19 UTC, Tim-Philipp Müller
none Details | Review
fix redirection again (3.67 KB, patch)
2006-05-12 12:02 UTC, Tim-Philipp Müller
committed Details | Review

Description j^ 2006-04-19 10:59:06 UTC
if you open a remote quicktime file with a link in totem, i.e.:
totem http://movies.apple.com/movies/sony_pictures/silent_hill/silent_hill_480p.mov
totem will fail to follow the link to silent_hill_h480p.mov

not sure if this is doe to totem failing to see that this is a relative link
or qtdemux doing something wrong
Comment 1 Tim-Philipp Müller 2006-04-19 13:17:34 UTC
Probably best to fix this in totem rather than just the GStreamer backend => re-assigning.
Comment 2 Tim-Philipp Müller 2006-04-19 13:19:50 UTC
Created attachment 63862 [details] [review]
propsed patch
Comment 3 Bastien Nocera 2006-04-23 23:53:26 UTC
xine-lib will give us non-relative redirections, which is why it worked. So instead, let's move this into the backends.

2006-04-24  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c:
        (bvw_handle_element_message):
        * src/backend/bacon-video-widget-gst.c:
        (bacon_video_widget_signal_idler):
        * src/backend/video-utils.c: (totem_resolve_relative_link):
        * src/backend/video-utils.h:
        * src/totem-mozilla-viewer.c: (on_got_redirect):
        * src/totem.c: (on_got_redirect):
        Make the GStreamer backends resolve relative redirects, as the
        xine-lib backend does (Closes: #339000)
        * src/plparse/totem-pl-parser.c: (totem_pl_parser_write_m3u):
        Save the full path when we can't get a relative path when saving m3u
        playlists (Closes: #338974)
Comment 4 Jan Schmidt 2006-05-08 13:48:53 UTC
It seems this isn't quite fixed. 

For the Firefox plugin, it's using fd://0 for the input, and that breaks the relative->absolute url logic. It ends up trying to redirect to fd://new-file-name.

Also, it seems that for Xine it only posts absolute urls when the input mrl is http:// or rtsp:// - so it breaks in the same way.

On the other hand with 1.4.0, this worked for me because it used the 'orig_filename' to perform the redirection at the mozilla-viewer.c level.
Comment 5 Jan Schmidt 2006-05-08 13:52:14 UTC
Oh btw, for examples try anything currently on trailers.apple.com - they all have relative urls in the mov files these days:

http://trailers.apple.com/trailers/disney/piratesofcaribbean2/large.html (http://movies.apple.com/movies/disney/piratesofthecaribbean2/piratesofthecaribbean2-tsr3_h.480.mov )

Comment 6 Tim-Philipp Müller 2006-05-12 12:02:39 UTC
Created attachment 65309 [details] [review]
fix redirection again

This patch fixes redirection for relative paths in the firefox viewer, at least when using the GStreamer backend.
Comment 7 Bastien Nocera 2006-05-14 10:48:23 UTC
I also fixed the 0.8 backend in gnome-2-14

2006-05-14  Bastien Nocera  <hadess@hadess.net>

        * NEWS: upd
        * src/backend/bacon-video-widget-gst-0.10.c:
        (bvw_handle_element_message):
        * src/backend/bacon-video-widget-gst.c:
        (bacon_video_widget_signal_idler):
        * src/backend/video-utils.c: (totem_resolve_relative_link):
        * src/totem-mozilla-viewer.c: (on_got_redirect):
        * src/totem.c: (on_got_redirect):
        Patch from Tim-Philipp Müller <tim at centricular dot net> to handle
        relative links in the front-end, as it knows the canonical mrl for the
        stream, and the backend doesn't, fixes Apple trailers playback in the
        Mozilla plugin (Closes: #339000)
Comment 8 Tim-Philipp Müller 2006-05-14 17:52:45 UTC
Thank you for backporting this to the 0.8 backend in the 2.14 branch as well, I honestly completely forget about it (out of sight, out of mind I guess).