After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338272 - Bad formed ping command when given a broadcast ip
Bad formed ping command when given a broadcast ip
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: Tools
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks:
 
 
Reported: 2006-04-12 21:23 UTC by Alejandro Andrés
Modified: 2006-04-14 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to ping broadcast addresses (1.44 KB, patch)
2006-04-14 14:53 UTC, Alejandro Andrés
committed Details | Review

Description Alejandro Andrés 2006-04-12 21:23:44 UTC
Please describe the problem:
When a broadcast ip is given to ping, it does not work. We can obviously attach
this to the bad formed ping command, wich should be used with a '-b'.
Should be easy to fix, no? :)

Steps to reproduce:
1.go to nettool->ping
2.ip: 255.255.255.255 (i.e.)
3. nothing happens... if we launch from the console, we see the msg (lack of -b)


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Germán Poo-Caamaño 2006-04-14 04:55:12 UTC
I wonder how does it works in Solaris.
Comment 2 Alejandro Andrés 2006-04-14 06:39:00 UTC
In Solaris there is no need for an extra parameter, you can ping a broadcast addr directly, the same as bsd*.

I wonder if the -b parameter in Linux environments is only for security reasons...

Ok, working on a patch.. :p
Comment 3 Germán Poo-Caamaño 2006-04-14 12:26:12 UTC
In that case, it is only needed to add -b by default. It will work fine for any kind of address.

I added the keyword gnome-love.
Comment 4 Alejandro Andrés 2006-04-14 14:53:56 UTC
Created attachment 63469 [details] [review]
Patch to ping broadcast addresses

I hope this works :)
Comment 5 Germán Poo-Caamaño 2006-04-14 17:03:50 UTC
The patch works fine in Linux.  Thank you!.

I applied to both stable and HEAD branches.