GNOME Bugzilla – Bug 337896
Volume Down Key Should Not Unmute
Last modified: 2007-07-01 16:46:41 UTC
First off, I'm not sure if I'm filing this bug against the right package. I'm talking about the volume control that pops up when you hit the volume keys on the keyboard (or whatever you have bound via the keyboard control panel). Reproducible: Always Steps to reproduce: 1. Hit Mute 2. Hit Volume Down Result: Volume level stays the same, and the volume is unmuted. Expected result: Volume level goes down one notch, and stays muted. This is useful, for example, if you have some loud sounds happen, and you want to turn down the volume. You could quickly hit mute to make it stop, then turn it down, then touch unmute (or up) to unmute it. Right now, there is no really easy way to deal with that situation. It's also just generally safer, as well. Hitting volume down is expected to make the volume quieter, or stay the same. If it's already muted, the only way to maintain that invariant is to implement the behavior described here. Unmuting results in the volume jumping from an effective zero to something possibly much higher. Note: I believe the correct behavior of Volume Up is correct. It unmutes, but doesn't actually raise the volume level that's been set. This is ideal. Other information:
Reassigning.
Created attachment 72131 [details] [review] Volume down key action This patch corrects the problem with volume down key as well the issue that it is not possible to completely mute volume using volume down key.
The indentation isn't nice, but looks good otherwise.
I'm not sure this is still valid, as I think another patch has been applied that sets the volume to zero if the mute is applied, and restores the original volume when mute is taken off.
It is bug 317507 I mentioned in my previous comment. Looks like the patch hasn't been committed yet.
Apparently, people have different opinions on when stuff should be muted/unmuted. FWIW, I don't agree with bug 317507. I'd like to be able to see what the volume level will be when I unmute (without blasting my ears away by having to unmute).
*** Bug 412606 has been marked as a duplicate of this bug. ***
I would like to define the master channel because the volume control on my keyboard affects master channel, but only PCM channel works!
(In reply to comment #8) > I would like to define the master channel because the volume control on my > keyboard affects master channel, but only PCM channel works! That has nothing to do with this bug, and it's already fixed in recent versions of GNOME.
2007-07-01 Jens Granseuer <jensgr@gmx.net> Patch by: Grzegorz Dymarek <gregd@interia.pl> * gnome-settings-multimedia-keys.c: (do_sound_action): don't unmute when lowering the volume and switch to muted when the volume reaches 0 (closes bug #337896)