After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337703 - DavSynDrum triggering broken
DavSynDrum triggering broken
Status: RESOLVED FIXED
Product: beast
Classification: Other
Component: plugins
SVN trunk
Other All
: Normal normal
: ---
Assigned To: Beast Maintainers
Beast Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-08 11:09 UTC by Stefan Westerfeld
Modified: 2006-05-16 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch which fixes the issue (1.85 KB, patch)
2006-05-15 20:15 UTC, Stefan Westerfeld 		none Details | Review

Description Stefan Westerfeld 2006-04-08 11:09:17 UTC 
Please describe the problem:
The DavSynDrum module doesn't work properly when triggered via its input  
channels for the first time. Only manually changing some parameter of the 
module with the GUI (or hitting the trigger button) resolves the problem, until 
the next restart of the audio engine.   

Steps to reproduce:
Play the DemoSong with a recent BEAST - the base drum track stays silent. 
Triggering with the trigger hit button or changing any of the other properties 
with the sliders resolves the problem. 

Actual results:


Expected results:


Does this happen every time?
Yes. 

Other information:
Comment 1 Stefan Westerfeld 2006-05-15 20:15:52 UTC 
Created attachment 65538 [details] [review]
Patch which fixes the issue

Please review. It may or may not be necessary to edit this patch for clarity, but it fixes the problem.
Comment 2 Tim Janik 2006-05-16 08:07:06 UTC 
thanks, the patch looks good to me. just a minor nit pick, since with your patch applied, self->params has the full state anyway when updating the modules, the g_memdup (&params, sizeof (params)); in that function can be changed to operate on self->params directly, so you can get entirely rid of the DavSynDrumParams param; variable.
other than that, please commit.
Comment 3 Stefan Westerfeld 2006-05-16 10:23:38 UTC 
Ok, committed it including your suggested change.