After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337593 - move glyph extents code (and cache) from pangocairo-*font.c into pangocairo-font.c
move glyph extents code (and cache) from pangocairo-*font.c into pangocairo-f...
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Behdad Esfahbod
pango-maint
Depends on:
Blocks: 347236 cairo_font_face_t
 
 
Reported: 2006-04-07 08:39 UTC by Behdad Esfahbod
Modified: 2007-06-10 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
committed patch (45.23 KB, patch)
2007-06-10 00:52 UTC, Behdad Esfahbod 		committed Details | Review

Description Behdad Esfahbod 2006-04-07 08:39:31 UTC 
The glyph extents code is cairo-backend agnostic.  It should be moved into pangocairo-font.c.

The code in pangocairo-fcfont is the reference code, with bug fixes and performance boosts, while the used-to-be-copies in win32 and atsui backends are just rotting.

For the record, I just made some rounding fix in pangocairo-fcfont.c, explained in https://bugs.freedesktop.org/show_bug.cgi?id=5200
Comment 1 LingNing Zhang 2006-04-26 09:54:05 UTC 
Can I add a object of the struct GlyphExtentsCacheEntry in the struct PangoCairoFont?
Comment 2 Behdad Esfahbod 2006-04-26 09:56:35 UTC 
No, the PangoCairoFont struct doesn't really exist.

I've got the patch for this.
Comment 3 LingNing Zhang 2006-04-26 10:01:31 UTC 
oh, I am writing the patch for this bug now.
:)
Comment 4 Behdad Esfahbod 2007-06-10 00:50:37 UTC 
2007-06-09  Behdad Esfahbod  <behdad@gnome.org>

        Bug 337593 – move glyph extents code (and cache) from
        pangocairo-*font.c into pangocairo-font.c

        * pango/pangocairo-fontmap.c:
        * pango/pangocairo-fcfontmap.c:
        Remove per-fontmap renderer.  We've not been using it for a while
        and there is no reason to use it.

        * pango/pangocairo-font.c
        * pango/pangocairo-fcfont.c: 
        Most most code (including glyph extents caching) from fcfont.c to 
        font.c.  Simplifies individual backends a lot. ATSUI and Win32 
        cairo backends should adapt.

        * pango/pangocairo-render.c
        * pango/pangocairo-private.h:
        Update to reflect above changes.
Comment 5 Behdad Esfahbod 2007-06-10 00:52:54 UTC 
Created attachment 89667 [details] [review]
committed patch