After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337129 - Compile warnings in G_IMPLEMENT_INTERFACE
Compile warnings in G_IMPLEMENT_INTERFACE
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 341472 (view as bug list)
Depends on: 337128
Blocks:
 
 
Reported: 2006-04-04 02:41 UTC by Behdad Esfahbod
Modified: 2006-05-16 12:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Behdad Esfahbod 2006-04-04 02:41:54 UTC 
The following patch turns off compile warnings in any code using G_IMPLEMENT_INTERFACE:

Index: gtype.h
===================================================================
RCS file: /cvs/gnome/glib/gobject/gtype.h,v
retrieving revision 1.63
diff -u -p -d -r1.63 gtype.h
--- gtype.h     27 Sep 2005 23:19:16 -0000      1.63
+++ gtype.h     4 Apr 2006 02:39:44 -0000
@@ -340,7 +340,9 @@ gpointer g_type_instance_get_private
  */
 #define G_IMPLEMENT_INTERFACE(TYPE_IFACE, iface_init)       { \
   static const GInterfaceInfo g_implement_interface_info = { \
-    (GInterfaceInitFunc) iface_init \
+    (GInterfaceInitFunc) iface_init, \
+    NULL, \
+    NULL \
   }; \
   g_type_add_interface_static (g_define_type_id, TYPE_IFACE, &g_implement_interface_info); \
 }

The patch doesn't work right now because of bug #337128 and the fact that it introduces commas in toplevel (not inside parantheses) of the code.
Comment 1 Behdad Esfahbod 2006-05-11 22:16:44 UTC 
*** Bug 341472 has been marked as a duplicate of this bug. ***
Comment 2 Tim Janik 2006-05-16 12:02:42 UTC 
fixed in CVS