After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337100 - [fakesink] add "preroll-handoff" signal
[fakesink] add "preroll-handoff" signal
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 336839 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-03 22:04 UTC by Julien MOUTTE
Modified: 2006-06-15 09:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch adding signal to preroll method. (615 bytes, patch)
2006-04-03 22:06 UTC, Julien MOUTTE 		needs-work Details | Review
Patch that adds a new signal for preroll handoff. (2.11 KB, patch)
2006-05-12 09:29 UTC, Julien MOUTTE 		committed Details | Review

Description Julien MOUTTE 2006-04-03 22:04:31 UTC 
when prerolling fakesink doesn't emit the handoff signal.
Comment 1 Julien MOUTTE 2006-04-03 22:06:13 UTC 
Created attachment 62702 [details] [review]
proposed patch adding signal to preroll method.
Comment 2 Wim Taymans 2006-04-06 13:34:15 UTC 
I prefer different signals for render and preroll as sending the same signal would break ABI for application that expect the signal to be called just once.
Comment 3 Julien MOUTTE 2006-05-12 09:29:45 UTC 
Created attachment 65302 [details] [review]
Patch that adds a new signal for preroll handoff.

That breaks ABI/API though
Comment 4 Tim-Philipp Müller 2006-05-16 13:19:09 UTC 
> Patch that adds a new signal for preroll handoff.
> 
> That breaks ABI/API though

How so?

I think this is perfectly find API/ABI-wise. We just add a new signal. There are no side-effects for applications not connecting to that signal. And the GstFakeSinkClass structure is private anyway, as the header files are not installed, so adding a field there shouldn't be a problem, just like with any other element.
Comment 5 Wim Taymans 2006-05-16 17:45:14 UTC 
I don't think it breaks anything..
Comment 6 Tim-Philipp Müller 2006-05-23 14:26:05 UTC 
Committed (with an added 'Since: 0.10.7' in the new signal's gtk-doc chunk):

 2006-05-23  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Julien Moutte  <julien at moutte net>

        * plugins/elements/gstfakesink.c: (gst_fake_sink_class_init),
        (gst_fake_sink_preroll):
        * plugins/elements/gstfakesink.h:
          Add new ::preroll-handoff signal (#337100).
Comment 7 Tim-Philipp Müller 2006-06-15 09:24:51 UTC 
*** Bug 336839 has been marked as a duplicate of this bug. ***