After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337022 - mixed line separators confuse gtk_text_iter_ends_line
mixed line separators confuse gtk_text_iter_ends_line
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-04-03 12:28 UTC by Paolo Borelli
Modified: 2006-04-05 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.02 KB, patch)
2006-04-03 12:30 UTC, Paolo Borelli 		committed Details | Review
unit test (589 bytes, patch)
2006-04-03 12:31 UTC, Paolo Borelli 		committed Details | Review

Description Paolo Borelli 2006-04-03 12:28:55 UTC 
This is a follow up bug of bug #336915 because I want to track other gedit/gtksourceview issues there. Marking as critical because it causes gedit crashes.

consider the following text:

1 foo\r
2 bar\n
3 baz
4 ...

place the cursor after 'bar' and hit delete 'bar' by pressing backspace 3 times.

1 foo\r
2 \n
3 baz
4 ...

\r and \n are two separate line terminators and should not be treated as a single \r\n terminator.

One of the problems of the current behavior is that using gtk_text_iter_forward_to_line_end on the second line causes the iterator to go back to the first line, which is unexpected and is the causes of crashes in gedit/gtksourceview.
Comment 1 Paolo Borelli 2006-04-03 12:30:05 UTC 
Created attachment 62664 [details] [review]
patch

This patch fixes the described issue, however it must be thought carefully if it could cause other unexpected side effects.
Comment 2 Paolo Borelli 2006-04-03 12:31:05 UTC 
Created attachment 62665 [details] [review]
unit test

here is a simple test program.
Comment 3 Paolo Borelli 2006-04-05 18:33:53 UTC 
committed after discussing with Matthias on irc.