After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336799 - PATCH: fix excell import crash
PATCH: fix excell import crash
Status: RESOLVED DUPLICATE of bug 161534
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
1.6.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-04-01 08:40 UTC by Hans de Goede
Modified: 2006-04-01 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
excell crash fix (360 bytes, patch)
2006-04-01 08:41 UTC, Hans de Goede 		none Details | Review

Description Hans de Goede 2006-04-01 08:40:11 UTC 
Hi,

First a short intro. I'm a Linux enthousiast / programmer and a packager
for Fedora Extras which is an online community that packages software in
the native package format for Fedora Core a (well known) Linux distribution.

As such I've taken over gnumeric maintainance from the Fedora Core developers, in the core package I inherited the attached patch is included, which seems sane. I think it might be a good idea to incorperate this in the next official release.
Comment 1 Hans de Goede 2006-04-01 08:41:02 UTC 
Created attachment 62513 [details] [review]
excell crash fix

Don't be put of by the version no, this patch still applies against 1.6.3
Comment 2 Jean Bréfort 2006-04-01 08:56:13 UTC 
Very strange. If length is less than 12 or 8 (according to biff version), the function already returns. Do you know where we could find a sample xls file showing the crash?
Comment 3 Hans de Goede 2006-04-01 09:26:40 UTC 
are you 100% sure, in that case its likely that those lenght checks are new, remember this patch was originally introduced against 1.4.1, maybe 1.4.1 didn't have those checks?

I'm just guessing here, as said I "inherited" this patch..... Digging through the changelog. This patch was added to the package because of:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=143161
Which points to:
http://bugzilla.gnome.org/show_bug.cgi?id=161534

Where Jody Goldberg claims it was already fixed in CVS (and presumably in another way?)

Anyways https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=143161 contains an attachment to reproduce that way we will know for sure. I assume you've a gnumeric without the patch attached to this bug compiled in handy so i'll leave the testing to you if you don't mind.
Comment 4 Jean Bréfort 2006-04-01 09:38:25 UTC 
OK, it is fixed in 1.6 and presumably some 1.4.x.

*** This bug has been marked as a duplicate of 161534 ***