After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336766 - BseWaveOsc doesn't restart when the user presses play again
BseWaveOsc doesn't restart when the user presses play again
Status: RESOLVED FIXED
Product: beast
Classification: Other
Component: bse
SVN trunk
Other All
: High normal
: m0.7
Assigned To: Beast Maintainers
Beast Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-31 20:00 UTC by Stefan Westerfeld
Modified: 2007-11-15 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (1.61 KB, text/plain)
2007-11-11 21:51 UTC, Stefan Westerfeld 		  Details
Patch which fixes BseWaveOsc retriggering (1.16 KB, patch)
2007-11-12 20:06 UTC, Stefan Westerfeld 		accepted-commit_now Details | Review

Description Stefan Westerfeld 2006-03-31 20:00:33 UTC 
Please describe the problem:
When BseWaveOsc is used in a synthesis (standalone) network and the user  
presses play while the network is already playing, the wave oscillator doesn't 
restart. 

Steps to reproduce:
 

Actual results:


Expected results:


Does this happen every time?
Yes. 

Other information:
Comment 1 Stefan Westerfeld 2007-11-11 21:51:12 UTC 
Created attachment 98937 [details]
Testcase

My initial assumption that only BseWaveOsc needs to be fixed was wrong. I am attaching a test case showing that the ADSR doesn't get a retrigger either if the user hits play again, after doing so once. Neither the ADSR code nor the BseWaveOsc code seem to be responsible. Something about the way BseProject is handling re-play seems to be wrong.
Comment 2 Stefan Westerfeld 2007-11-12 20:06:02 UTC 
Created attachment 98987 [details] [review]
Patch which fixes BseWaveOsc retriggering

Tried and tested (also passes make report) patch which fixes the problem.
Comment 3 Tim Janik 2007-11-15 19:43:14 UTC 
(In reply to comment #2)
> Created an attachment (id=98987) [edit]
> Patch which fixes BseWaveOsc retriggering
> 
> Tried and tested (also passes make report) patch which fixes the problem.

thanks, looks good, please apply.
Comment 4 Stefan Westerfeld 2007-11-15 21:51:00 UTC 
Applied.

Mon Nov 12 21:00:10 2007  Stefan Westerfeld  <stefan@space.twc.de>

        Fix module reset when user presses play again, bug #336766.

        * bseproject.c (bse_project_stop_playback): When this method is
        called, we need to dismiss the contexts of the BseSuper classes
        we previously created in bse_project_start_playback.