After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336192 - QIF Import: Allow new namespaces when defining new securities
QIF Import: Allow new namespaces when defining new securities
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Import - QIF
git-master
Other All
: Normal minor
: ---
Assigned To: Charles Day
Derek Atkins
Depends on:
Blocks: backport
 
 
Reported: 2006-03-27 13:50 UTC by Mark Johnson
Modified: 2018-06-29 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (9.45 KB, patch)
2008-04-19 03:05 UTC, Charles Day
committed Details | Review

Description Mark Johnson 2006-03-27 13:50:53 UTC
When the QIF import druid is asking the user for information about each 
security, it presents a pulldown list from which the user selects a stock 
exchange (or other security type).  When the user manually enters a security 
type (in my case TSX, but there are many exchanges in the world), the QIF 
import druid should add that to the pulldown list for subsequent appearances of 
the this page.  It would be helpful as the user would not have to enter it 
every time. 
 
 

Other information:
SVN version is 13702. 
Related bug: 123312.
Comment 1 Josh Sled 2007-04-21 18:19:22 UTC
With svn/trunk@15951 / 2.1.x, I can't even find an option/ability to enter a different stock exchange.  What do you mean?
Comment 2 Mark Johnson 2007-04-28 09:48:52 UTC
It's been a while, but I'm pretty sure the means of entering the stock exchange was via a "combo box" rather than a "pulldown list".  Sorry for any confusion.

Of course, I was using a considerably older version.  I haven't had a chance to try any 2.1.x versions.
Comment 3 Derek Atkins 2008-04-17 22:21:34 UTC
When was it a combo box?  (Just interested in looking at the actual history and want a good place to start looking)
Comment 4 Charles Day 2008-04-18 16:54:39 UTC
I don't know the history, but in 2.2.4 it is implemented as a combo box (gtkComboBoxEntry widget) and the callbacks then de-fang it so that it behaves effectively as a dropdown list.

I am working on changing it to allow new entries to be made.

Alternatively, I could leave the combo box as-is, and instead add a "New" button for the user to click if they genuinely intend to create a new namespace. But that would be harder to implement, and sort of defeats the purpose of a combo box.
Comment 5 Charles Day 2008-04-19 03:05:46 UTC
Created attachment 109517 [details] [review]
Proposed patch

Here's my proposed patch, if anyone would like to test it or point out any silly mistakes. I briefly tested it, and I think it works correctly, but I won't commit it until I get back from traveling in early May.

P.S. There are few unrelated fixes for memory leaks included.
Comment 6 Charles Day 2008-05-11 16:59:13 UTC
Patch committed as r17150. Requesting backport for 2.2.
Comment 7 Andreas Köhler 2008-07-20 23:57:26 UTC
Applied to branches/2.2 as r17356 for inclusion in GnuCash 2.2.6.
Thanks!
Comment 8 John Ralls 2018-06-29 21:00:31 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=336192. Please update any external references or bookmarks.