GNOME Bugzilla – Bug 336121
Import Recent files code from libegg
Last modified: 2006-04-17 20:33:45 UTC
Tracker bug for importing the code living in libegg/recentchooser into gtk+, pending the import of the parser code (libegg/bookmarkfile) into glib.
Created attachment 62074 [details] [review]
Preliminary version of the import
This is a patch against HEAD.
It includes all the GtkRecent* stuff, plus a couple of changes from the libegg code; a test suite similar to the FileChooser one; documentation; a migration guide, for people moving from the old EggRecent code.
Here are some small things I noticed in the included docs, not necessarily
- missing short/long descriptions
- some functions are missing since tags
- Maybe we should group the recent files classes
into their on chapter, and add an introductory section like
we have for the textview/treeview
- seems that including struct docs in headers doesn't quite work
(generates bad output)
- in migration guide, should suppress links in examples
- I think the migration guide should have a concrete example
old code vs. new code
some more things (already mentioned on irc)
- gtk_recent_chooser_menu_init and gtk_recent_chooser_default_init need to initialize show_icons to TRUE
Another thing is adding aliasing, but I can handle that after the patch is merged.
I've merged a fixed version of the patch above, along with the API for setting the screen singleton manager and the constructor property requested in
> - missing short/long descriptions
> - some functions are missing since tags
Fixed before merge.
> - Maybe we should group the recent files classes
> into their on chapter, and add an introductory section like
> we have for the textview/treeview
The introductory section is still missing, but the grouping inside the "Recently Used Documents" section is done. We can revert later, if we want to move the recent chooser widgets to the selector widgets section.
> - gtk_recent_chooser_menu_init and gtk_recent_chooser_default_init need to
> initialize show_icons to TRUE
> - adding aliasing
Fixed before merging.
> - seems that including struct docs in headers doesn't quite work
> (generates bad output)
> - in migration guide, should suppress links in examples
> - I think the migration guide should have a concrete example
> old code vs. new code
> - Add a GtkRecentChooserMenu to the appwindow demo in gtk-demo
For these I'll attach a patch to this bug.
This is fantastic! Thanks for merging this, Emmanuele!
Created attachment 63718 [details] [review]
long descriptions for the api doc
long descriptions for the gtkrecent* template files
Small typo: shouldn should be should
Otherwise, it looks fine to commit.
I'll close this now. Please open a new one for ui manager integration