After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335811 - Some conjugates of Malayalam are wrong.
Some conjugates of Malayalam are wrong.
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: indic
unspecified
Other All
: Normal blocker
: ---
Assigned To: Behdad Esfahbod
Pango Indic
Depends on:
Blocks:
 
 
Reported: 2006-03-24 09:41 UTC by LingNing Zhang
Modified: 2006-07-31 05:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The right conjugates of Malayalam (86.02 KB, image/png)
2006-03-24 09:43 UTC, LingNing Zhang
  Details
the wrong conjugates of Malyalam (90.06 KB, image/png)
2006-03-24 09:45 UTC, LingNing Zhang
  Details
conjugates after modifying (94.21 KB, image/png)
2006-03-24 09:57 UTC, LingNing Zhang
  Details
my patch (1.01 KB, patch)
2006-07-07 02:38 UTC, LingNing Zhang
committed Details | Review
the image (80.16 KB, image/png)
2006-07-07 02:47 UTC, LingNing Zhang
  Details

Description LingNing Zhang 2006-03-24 09:41:02 UTC
Please describe the problem:
I found that some conjugates of Malayalam in Pango are wrong.
They are:
(1) (U+0d37) + (U+0d4d) + (U+0d1f)
(2) (U+0d28) + (U+0d4d) + (U+0d26)
(3) (U+0d1f) + (U+0d4d) + (U+0d1f)
(4) (U+0d23) + (U+0d4d) + (U+0d23)
(5) (U+0d26) + (U+0d4d) + (U+0d26)
(6) (U+0d38) + (U+0d4d) + (U+0d25)
(7) (U+0d24) + (U+0d4d) + (U+0d25)
(8) (U+0d23) + (U+0d4d) + (U+0d1f)
(9) (U+0d28) + (U+0d4d) + (U+0d25)
(10) (U+0d2c) + (U+0d4d) + (U+0d26)
(11) (U+0d15) + (U+0d4d) + (U+0d1f)

The images of the right conjugates and the wrong conjugates are below.
Font used for rendering is Thoolika Unicode
http://www.supersoftweb.com/THOOLIUC.TTF


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 LingNing Zhang 2006-03-24 09:43:23 UTC
Created attachment 61897 [details]
The right conjugates of Malayalam

This is the image of the right conjugates of Malayalam.
Comment 2 LingNing Zhang 2006-03-24 09:45:30 UTC
Created attachment 61898 [details]
the wrong conjugates of Malyalam

This is the image of the wrong conjugates of Malayalam in Pango.
Comment 3 LingNing Zhang 2006-03-24 09:55:21 UTC
I found that the reason that creating the wrong conjugates in Pango.
In the IndicOTCharClass mlymCharClasses, the tags that U+0d1f, U+0d23, U+0d25 and U+0d26 are all _bb, and I think they need be not _bb and need be _ct.
So I modified them, and build again.
Then most of the conjugates are right, except the first conjugate.
I will debug and test them.
The result of rendering these conjugates is below.
Comment 4 LingNing Zhang 2006-03-24 09:57:13 UTC
Created attachment 61899 [details]
conjugates after modifying

This is the image of rendering the conjugates of Malayalam after modifying.
Comment 5 Carthik Sharma 2006-03-30 17:45:08 UTC
Hi,

Gora from indlinux referred me to this and other Malayalam bugs in pango, and I can help you out here.

Your fixes in http://bugzilla.gnome.org/attachment.cgi?id=61899&action=view look right, except for the first one (first line), which should be as it is in 
http://bugzilla.gnome.org/attachment.cgi?id=61897&action=view

Please note that in 
http://bugzilla.gnome.org/attachment.cgi?id=61898&action=view and
http://bugzilla.gnome.org/attachment.cgi?id=61899&action=view

is relatively easy to find that the first line is being rendered with the wrong character (the character is the same as the one on line two) so maybe that is an input error, involving switched numbers or similar. To be more specific, look at the characters on the right hand side of the equality sign. In the top two lines, the "Na" character, which looks like a "3" facing downward is used instead of the "Sha" character. This might be an input error and not a bug, maybe.
Comment 6 LingNing Zhang 2006-03-31 03:45:19 UTC
I found that the unicodes of the first line need be  (U+0d37) + (U+0d4d) + (U+0d1f), but the unicods that I input are (U+0d28) + (U+0d4d) + (U+0d1f). So it is wrong.
:)
Comment 7 LingNing Zhang 2006-03-31 09:42:47 UTC
I wrote a patch for fixing this bug and bug121672.
The patch is:
http://bugzilla.gnome.org/attachment.cgi?id=62443&action=view
Comment 8 LingNing Zhang 2006-03-31 09:45:39 UTC
I think that the mlymCharClasses can not be modified. So I added some codes to handle the malayalam special conjugates.
Comment 9 LingNing Zhang 2006-04-12 06:16:14 UTC
The patch is modified for fixing the bug about (U+0d32) + (U+0d4d) + (U+0d32).
The patch is:
http://bugzilla.gnome.org/attachment.cgi?id=63283&action=view
Comment 10 LingNing Zhang 2006-07-07 02:38:50 UTC
Created attachment 68515 [details] [review]
my patch

I found that Qt can render these conjuctions' glyphs rightly, so I read the codes about indic of Qt. Then I found some consonants' tags in the indicOTCharClass of pango are different with the same tags in Qt.
I modified these tags through refering to the tags of Qt, and tested them.
These conjuctions' glyphs render rightly.
:)
Comment 11 LingNing Zhang 2006-07-07 02:47:37 UTC
Created attachment 68516 [details]
the image

the image of rendering these conjuctions
Comment 12 Behdad Esfahbod 2006-07-31 05:18:09 UTC
2006-07-31  Behdad Esfahbod  <behdad@gnome.org>

        Bug 335811 – Some conjugates of Malayalam are wrong.
        Patch from LingNing Zhang

        * modules/indic/indic-ot-class-tables.c: Update consonant tags to
        fix conjugates.