After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335447 - Beagle-live contact behavior is incorrect
Beagle-live contact behavior is incorrect
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
2.14.x
Other All
: Normal minor
: 2.16
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
: 335478 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-22 02:59 UTC by Boaz Haberman
Modified: 2006-04-07 15:08 UTC
See Also:
GNOME target: 2.16.x
GNOME version: 2.15/2.16


Attachments
Working patch (498 bytes, patch)
2006-03-24 00:16 UTC, Boaz Haberman
none Details | Review

Description Boaz Haberman 2006-03-22 02:59:33 UTC
Please describe the problem:
If the "Send email to ...." link is clicked in the deskbar results, a useless
contact information window opens up in evolution, instead of an actual "Compose
Mail" window in the user's preferred client.

Steps to reproduce:
1. Add a contact to the evolution address book
2. Enable beagle-live and the beagle evolution backend
3. Type the name of the contact in the deskbar
4. Click the "Send email to..." link

Actual results:
Evolution opens, along with a window allowing the user to edit that contact's
information

Expected results:
Since the link says "Send email to...", I would expect a compose mail window to
open in the user's preferred email application.

Does this happen every time?
Yes

Other information:
Patch:
--- beagle-live.py.old  2006-03-21 21:34:45.000000000 -0500
+++ beagle-live.py      2006-03-21 21:36:32.000000000 -0500
@@ -56,13 +56,14 @@
 #  The templates are a tuple of strings which should be tested in order to
retreive the beagle property

 TYPES = {
-       "Contact"       : {
-               "name"  : ("fixme:FileAs",),
-               "action": "evolution %(uri)s",
-               "icon"  : "stock_contact",
-               "description": _("Send Email to %s") % "<b>%(name)s</b>",
-               "category": "people",
-               },
+        "Contact"       : {
+                "name"  : ("fixme:FileAs",),
+               "action": lambda d: gnome.url_show('mailto:"%(name)" <%s>' %
d["email"]),
+                "icon"  : "stock_contact",
+                "description": _("Send Email to %s") % "<b>%(name)s</b>",
+                "category": "people",
+                "extra" : {"email" : ("fixme:Email",)}
+                },

        "MailMessage"   : {
                "name"  :("dc:title", "parent:dc:title"),
Comment 1 Mikkel Kamstrup Erlandsen 2006-03-22 09:09:02 UTC
Another possibility would be to just change the hit text to: "Open contact: blah" - since we already have a few ways to send emails with deskbar? But I don't know...
Comment 2 Boaz Haberman 2006-03-22 11:32:24 UTC
That doesn't seem like incredibly useful behavior, as people send emails more often than they update contacts. Besides, Beagle seems a lot more flexible to me, and it seems more robust to just use the beagle search plugin instead of having a different plugin to do the exact same thing, especially since the address book plugin looks to be highly dependent on evolution.

Having both options, on the other hand, could be nice, albeit cluttered.
Comment 3 Boaz Haberman 2006-03-24 00:16:21 UTC
Created attachment 61877 [details] [review]
Working patch

The patch submitted with the bug doesn't actually work. Here is a new one.
Comment 4 Boaz Haberman 2006-03-24 00:20:34 UTC
Another problem is that the address book handler does not actually work (at least for me). I think search therefore is more robust than autocomplete (I know this is anecdotal).
Comment 5 Sergej Kotliar 2006-04-02 20:11:25 UTC
*** Bug 335478 has been marked as a duplicate of this bug. ***
Comment 6 Raphael Slinckx 2006-04-07 00:50:46 UTC
Marking for 2.16 We'll soon evaluate what to do with this after we get some bug fixed for 2.14
Comment 7 Raphael Slinckx 2006-04-07 15:08:59 UTC
Ok, so we will use that patch in 2.14 branch to do what we say (and we're string-freezed);

In 2.16 however we will change the string to say 'Edit contact %s' and open the contact editor