GNOME Bugzilla – Bug 335410
add X-GNOME-Bugzilla keys to evolution.desktop
Last modified: 2006-06-14 12:16:27 UTC
Please describe the problem: evolution.desktop must have X-GNOME-Bugzilla-Bugzilla=GNOME to appear in bug buddy. And "Application" is not a freedesktop.org registred category. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 61722 [details] [review] add X-GNOME-Bugzilla keys
vincent, are you sure that evolution.desktop must have X-GNOME-Bugzilla-Bugzilla=GNOME to appear in bug buddy? please see olav's report at bug 307176. setting this to NEEDINFO. according to http://standards.freedesktop.org/menu-spec/latest/apa.html you're right that application is not a freedesktop.org registered category. but "X-Red-Hat-Base" isn't either. i guess we should also add "Email;Calendar;ContactManagement" to the categories list.
Yeah, I'm sure, see my screenshots at http://hedinux.org/screenshots/evolution/ X-Red-Hat-Base is not a freedesktop.org registred category, but it have the "X-" prefix, so it's fine. But we can remove it too. And you're right, we should add "Email;Calendar;ContactManagement;" categories.
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/bug-buddy/+bug/35729 from IRC: <iegary> seb128: the line I added which caused it to work was: X-GNOME-Bugzilla-Bugzilla=GNOME
olav, are you sure with your comment at bug 307176 that we do not need a X-GNOME-Bugzilla-Bugzilla=GNOME line in data/evolution.desktop.in.in? we have this bug report here, and also one in ubuntu: http://launchpad.net/bugs/35729 tia
*** Bug 329131 has been marked as a duplicate of this bug. ***
olav: ping?
Yes, is needed. Really thought it was optional :-(
The following key will be needed soon (2.15.3) too: X-GNOME-Bugzilla-Component=
Is the Category 'Application' no longer needed? Any others that need to be considered ? The rest of the patch looks fine.
desktop-file-validate from desktop-file-utils 0.11 package checks the categories now. Application is not a registred category, it have to be removed. The freedesktop standard allow to add new categorie that don't exist in the standard, but it have to begin with X-
desktop-file-validate from desktop-file-utils 0.11 package checks the categories now. Application is not a registred category, it have to be removed. For the categories, you should use Categories=GNOME;GTK;Office;Email;Calendar;ContactManagement;
Approved for commit on HEAD.
harish, why not fixing this in the gnome-2-14 branch also? ok, to avoid confusion: i propose to add +X-GNOME-Bugzilla-Bugzilla=GNOME +X-GNOME-Bugzilla-Version=@BASE_VERSION@.x as proposed in the patch and change Categories to +Categories=GNOME;GTK;Office;Email;Calendar;ContactManagement;X-Red-Hat-Base; to merge the patch *and* vincent's comment and add +X-GNOME-Bugzilla-Component=Evolution as proposed by olav in comment 9.
(In reply to comment #14) > harish, why not fixing this in the gnome-2-14 branch also? Just that it could use some testing love in HEAD before adding it to gnome-2-14. There are deployments with more recent version of Evolution running on old deployments etc. They play with HEAD and usually catch issues that escape local testing. > ok, to avoid confusion: > > i propose to add > +X-GNOME-Bugzilla-Bugzilla=GNOME > +X-GNOME-Bugzilla-Version=@BASE_VERSION@.x > as proposed in the patch > > and change Categories to > +Categories=GNOME;GTK;Office;Email;Calendar;ContactManagement;X-Red-Hat-Base; > to merge the patch *and* vincent's comment > > and add > +X-GNOME-Bugzilla-Component=Evolution > as proposed by olav in comment 9. > Can you update the patch with the component too ? TIA.
Created attachment 67191 [details] [review] updated patch see comment 14 and 15.
damn, that "X-GNOME-Bugzilla-Component=" part is definitely wrong. olav, can you explain to me how it works? leaving the value empty like "X-GNOME-Bugzilla-Component="? or is it only a fallback value (so i would enter "Miscellaneous" here)? i have no clue about that at all. :-(
For current Bug-Buddy versions it will select the default component. So it should read: X-GNOME-Bugzilla-Component=Miscellaneous In future, Bug-Buddy will only ask for 'steps to reproduce' and email address. Questions like product/component/etc have been removed. These must all be provided by the .desktop file.
Created attachment 67194 [details] [review] updated patch updated patch as described by olav
*** Bug 329141 has been marked as a duplicate of this bug. ***
Approved.
patch committed to HEAD: http://cvs.gnome.org/viewcvs/evolution/data/evolution.desktop.in.in?r1=1.13&r2=1.14 fix will be included in unstable evolution 2.7.4. not closing the bug as harish has to decide whether it should also go into stable branch as well (see comment #15). evolution 2.6.3/gnome 2.14.3 tarballs are planned for monday, 31st of july.
Andre : let us get it committed in the stable branch so it gets tested before the 2.6.3 release. We will fix/revert if necessary.
patch also committed to stable branch: http://cvs.gnome.org/viewcvs/evolution/data/evolution.desktop.in.in?r1=1.13&r2=1.13.2.1 fix will be included in stable evolution 2.6.3. thanks a lot everybody, closing as fixed.