GNOME Bugzilla – Bug 335300
[PATCH] random Context fixes
Last modified: 2006-03-23 16:33:13 UTC
1) inFill and inStroke need to be public so they can actually be used 2) Context shouldn't be passing back a Handle based on a function-local variable 3) font options need to be allocated before being passed into cairo, just like cairo_matrix_t types do. cairo_get_font_options() _copies_ an internal matrix into the supplied one, so in the case here we go boom because we pass in NULL.
Created attachment 61654 [details] [review] Context fixups
We should close https://bugs.freedesktop.org/show_bug.cgi?id=5945 when this gets closed.
Dan, If I remember correctly, last time we talked you indicated that you didn't think you'd be able to commit to cairo-java as hosted by freedesktop.org. Is that the case? If so, I can bug them to get you write access. AfC
Correct, I only have commit privs to desktop-file-utils or whatever that module is called now. So I've got an account on fdo, just not privs for cairo-java.
Request made: https://bugs.freedesktop.org/show_bug.cgi?id=6330 ; but there is no reason to hold up these patches. If you need|want feedback on them, then please ping Remy or Ismael, otherwise, let one of us know and we'll commit them. We're just about to cut a release and I'd like to see these fixes in cairo-java before we do. Cheers, AfC
Dan, You probably didn't notice, but Carl took care of https://bugs.freedesktop.org/show_bug.cgi?id=6330 and you've been granted write permissions to cairo-java in cvs.freedesktop.org. As Carl said, "Happy Hacking"! With that in hand, would you care to take care of committing your patches to this, 335301, 335303, and 335304? I am marking them NEW and assiging them to you; you can ACCEPT, RESOLVE or bounce them back for further discussion as you see fit. You've been making an amazing contribution; on behalf of everyone both inside java-gnome and throughout the user community, many many thanks. AfC
Committed to CVS.