GNOME Bugzilla – Bug 334888
sftp locations not accessible from gtkfilechooser
Last modified: 2007-01-08 22:26:57 UTC
Please describe the problem: I first tried to report about "directory symlinks on ssh locations not choosable in gtkfilechooser", but then I saw this patch: http://mail.gnome.org/archives/gnome-vfs-list/2006-March/msg00022.html Now links to directories show up nicely with directory icon, but somehow the ssh:// locations are not choosable from the gtkfilechooser. Steps to reproduce: 1. Apply the patch from http://mail.gnome.org/archives/gnome-vfs-list/2006-March/msg00022.html 2. Use "Take Screenshot" tool 3. Try to choose a ssh:// location to save the screenshot Actual results: The contents of the ssh:// locations don't show up Expected results: The contents show up. Does this happen every time? Other information: I try to reverse this patch to see if it's caused by it.
After reversing this patch, the sftp location worked for me, but I would like to hear another success/failure about this issue :)
Thanks, good catch! This also doesn't work for the http (neon) method. The file chooser seems to query sftp://foohost for determining the name of the toplevel button, which used to return GNOME_VFS_OK and filename "." but now returns GNOME_VFS_ERROR_NOT_FOUND. I'm not sure how common it is to have path-less URIs.
Created attachment 61448 [details] dot-marks-the-spot.png You mean this dot which is marked on the screenshot?
Exactly. gnomevfs-info returns a valid file info with filename "." for me if I call it on an sftp hostname without the symlink patch. It really shouldn't, IMHO the GTK+ GnomeVFS file system should handle this situation better, I'm currently investigating it.
Reassigning to libgnomeui, the problem was indeed in GTKFileSystemGnomeVFS.
Created attachment 61452 [details] [review] Proposed libgnomeui patch
Why does it matter whether we have a trailing slash or not? [There's another bug about typing C-l, then "http://www.openoffice.org" and getting nothing; someone evidently wants to load the HTML page there. Would this patch fix that problem?]
(In reply to comment #6) > Created an attachment (id=61452) [edit] > Proposed libgnomeui patch Works like charm.. And this dot in location buttons is replaced with "sftp://user@host/" > [There's another bug about typing C-l, then "http://www.openoffice.org" and > getting nothing; someone evidently wants to load the HTML page there. Would > this patch fix that problem?] Pressing C-l then typing "http://www.openoffice.org" (without quotes) gives an error: -- Could not retrieve information about the file error accessing 'sftp://amd@store20.com/home/amd/http%3A%2F%2Fwww.openoffice.org': File not found -- Pressing C-l then typing "http://www.openoffice.org/" (without quotes and trailing slash) gives an error: -- The folder contents could not be displayed http://www.openoffice.org/ is not a folder --
This depends on #153679
bug 153679 has been fixed it seems. Is this patch ok to commit?
Kjartan, thumbs up from me :)
Go ahead and commit :)
Committed (r5216).
Updating version, closing.