GNOME Bugzilla – Bug 334453
Remove song links
Last modified: 2006-10-18 16:18:25 UTC
So, I think we should remove the artist/album links. I think there are a few compelling reasons for this. * There is really no sane way to properly allocate space for 6 discrete containers on a horizontal * The vertical alignment was wrong - the song label and album labels were on different baselines * The actions were too close to the toolbar and were confusing (especially since the links are so inviting to click) * There is no feedback while a web browser is loading * The GnomeUrl API is deprecated * GnomeUrl is broken in at least a few ways: ellipsing, theming * We can't decide what the proper action should be * We should implement links or menus via plugins From watching people use RB almost everyone clicks on those links and they rarely expect it to do what it does. So, I propose that we remove this now and add something back later as a plugin. If we even miss it (I realized that I never use these links).
Created attachment 61187 [details] [review] patch Look OK?
I like the links, and I think the right solution is what James proposed on the ML, which is to have a special artist/album window (maybe this could be a plugin). This is discussed on bug #331250. Specifically note the discussion from here: http://bugzilla.gnome.org/show_bug.cgi?id=331250#c2
I suggest this bug be closed as dupe of bug #331250 and discussion be followed up there to make sure interested parties know about it.
I know about that bug. This doesn't necessarily preclude doing that because you couldn't use GnomeUrl for that anyway. The way it is now is just embarassingly broken.
The album/artist info stuff could be easily added with a plugin, as was mentioned. I'd be happy for this to be committed.
(In reply to comment #4) > I know about that bug. This doesn't necessarily preclude doing that because > you couldn't use GnomeUrl for that anyway. The way it is now is just > embarassingly broken. Fair enough, maybe we could have an artist info plugin before the next release to go in it's place. ;-)
*** Bug 363175 has been marked as a duplicate of this bug. ***