After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333917 - double-free bug
double-free bug
Status: RESOLVED DUPLICATE of bug 335432
Product: gnome-applets
Classification: Other
Component: mixer
2.14.x
Other Linux
: Immediate normal
: 2.14
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 333927 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-08 15:56 UTC by Matthias Clasen
Modified: 2010-01-24 01:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
the described fix (1.63 KB, patch)
2006-03-08 18:25 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2006-03-08 15:56:52 UTC 
Originally filed here: 
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184285

Also see 
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182957
for the consequences

The problem is that the mixer applet sometimes uses 
g_object_set_data_full and sometimes g_object_set_data to set
gnome-volume-applet-origname and gnome-volume-applet-name.

And then it does a nasty g_free (g_object_get_data ()) in dispose. 

It should always use set_data_full() and let glib take care of
freeing the value when the object is disposed.
Comment 1 Danielle Madeley 2006-03-08 16:04:02 UTC 
So you're recommending the inclusion of https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=125807 ?
Comment 2 Matthias Clasen 2006-03-08 16:20:21 UTC 
A better patch will be available shortly
Comment 3 Allison Karlitskaya (desrt) 2006-03-08 17:32:42 UTC 
*** Bug 333927 has been marked as a duplicate of this bug. ***
Comment 4 Matthias Clasen 2006-03-08 18:25:28 UTC 
Created attachment 60930 [details] [review]
the described fix
Comment 5 Ronald Bultje 2006-03-09 13:29:59 UTC 
(On my current source tree, which is somewhere halfway the 2.13 cycle:)

[rbultje@localhost mixer]$ grep g_object_set_data_full *
[rbultje@localhost mixer]$

? I don't see this bug. Is this a fedora-specific bug or did someone commit a bad patch?
Comment 6 Matthias Clasen 2006-03-09 13:34:14 UTC 
I don't know where the set_data_full calls came from, but in any case,
they are much more correct than this:

 g_free (g_object_get_data (G_OBJECT (element),
                            "gnome-volume-applet-name"));
Comment 7 Ronald Bultje 2006-04-09 02:53:47 UTC 
I'm ok with this patch, please apply.
Comment 8 Danielle Madeley 2006-04-09 03:06:11 UTC 
Once this is in, I'll roll a 2.14.1 tarball and then branch.
Comment 9 Danielle Madeley 2006-04-10 08:20:35 UTC 
This fix looks like it went in with bug #335432. Can someone please confirm?
Comment 10 Kjartan Maraas 2006-05-07 11:01:48 UTC 
Looks like it yeah. Marking as duplicate.

*** This bug has been marked as a duplicate of 335432 ***