GNOME Bugzilla – Bug 333821
randomly(?) attempts to ping server when offline
Last modified: 2013-09-10 14:04:20 UTC
Please describe the problem: Attached picture pretty much says it all; it attempts to ping the IMAP server while I'm offline for some reason. Of *course* I have to be online, so *don't ping the server*. Don't try to ping it, and then give me an error message randomly... Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 60877 [details] Shows weird/stupid error message.
at least a second person which can also see this behaviour.
Seeing this on 2.6.0 final as shipped by FC5.
*** Bug 334346 has been marked as a duplicate of this bug. ***
we will get many, many bug reports dealing with this as it is very visible and intrusive. perhaps a duplicate of bug 329712. shres?
*** Bug 334932 has been marked as a duplicate of this bug. ***
bug 329712: Is just a case of network being up and evolution --offline being used. This bug is much more serious and not a duplicate.
Groan, suckage
+ Trace 67094
which means imap_noop needs to call camel_imap_store_connected to know the network state. Which sets an exception which the ui picks up :(
Created attachment 61679 [details] [review] Patch to fix the issue
boy, this is really annoying. any news on this?
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/evolution/+bug/38154 "Since I use Dapper I have a strange and senseless error, while I am working offline: "Error while Pinging IMAP server imap4.vr.in-berlin.de. You must be working online to complete this operation" This error comes 5-10minutes after I go offline and then every X minutes (maybe 10 or 15minutes), after I click on ok. I am working offline in evolution, because I don't have a network connection and I didn't want that evolution try to connect a server. Why evolution tries to "ping" an IMAP server, when I am offline. This seems to be a bug." Any reason to not use the patch from that bug before GNOME 2.14.1?
shres, today i applied your patch to yesterday's checkout of cvs head and it does not fix the issue for me. i still get the same popups. suse9.3/gnome2.10
*** Bug 340677 has been marked as a duplicate of this bug. ***
Sankar: Can you look into this?
Any news on this patch?
*** Bug 342117 has been marked as a duplicate of this bug. ***
It is really annoying. bumping the priority.
Created attachment 68855 [details] [review] patch
How did you arrive at the conclusion that noop is the function that tries to make the n/w call? Anyway, on imap_noop I see: CAMEL_SERVICE_LOCK (imap_store, connect_lock); if (!camel_imap_store_connected(imap_store, ex)) goto done; <code> done: CAMEL_SERVICE_LOCK (imap_store, connect_lock); So, I dont think noop will try to ping the server if the imap_store is not connected. Am I missing something ?
The statement below the "done" label is: CAMEL_SERVICE_UNLOCK (imap_store, connect_lock); Sorry for the Copy & Paste error...
The API doc says : /** * camel_store_noop: * @store: a #CamelStore object * @ex: a #CamelException * * Pings @store so that its connection doesn't timeout. **/ camel_imap_store_connected calls camel_disco_store_check_online which sets the exception. (so therez no actual pinging. just the error)
Varadhan has a better fix for this issue. Adding Varadhan to cc list.
varadhan: *poke*. this must get into 2.6.3!
bnc bug https://bugzilla.novell.com/show_bug.cgi?id=194416
Camel library shouldn't do any such checks. The application should be doing the checks. Attaching an appropriate fix.
Created attachment 69635 [details] [review] Fix. Patch applies to CVS HEAD.
Atlast we have a fix for this. Awesome Varadhan :)
Thanks, Srini. (don't know whether this is a sarcasm. ;-), anyway, taking in usual way) Patch committed both to 2.6.3 and HEAD. @Andre: Special thanks for poking me. ;-)
No Sarcasm really :) This is one bug, I saw in every one's laptop in GUADEC and I hate to see it again. Thx dude.
Verified in 2.6.3.