After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333786 - visual disk panel : borders clumbsy
visual disk panel : borders clumbsy
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other All
: Normal minor
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2006-03-07 19:04 UTC by gnutter
Modified: 2006-03-18 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to achieve above (1.98 KB, patch)
2006-03-07 19:06 UTC, gnutter
none Details | Review
screenshot of result (69.71 KB, image/png)
2006-03-07 19:10 UTC, gnutter
  Details

Description gnutter 2006-03-07 19:04:50 UTC
In relation to the rest of the interface I find the wide of the borders rather 
clucky. It gives a rather primitive out of date look.

Suggest a smaller width of 5 px.

Other information:
Comment 1 gnutter 2006-03-07 19:06:58 UTC
Created attachment 60856 [details] [review]
patch to achieve above

patch to allow thinner border width , without losing hightlight rectangle on selection.
Comment 2 gnutter 2006-03-07 19:10:34 UTC
Created attachment 60857 [details]
screenshot of result
Comment 3 Plors (Bart H) 2006-03-07 19:23:05 UTC
heh, i'm just looking into cairo to draw the visual representation of the layout :)

I have been experimenting with smaller borders before (simply a matter of adjusting BORDER), but the main problem is the fact it harder to distinguish the colors imho.

Anyway, let's see what cairo can do for us :)
Comment 4 Plors (Bart H) 2006-03-07 20:43:23 UTC
i just found out cairo will only be included in gtkmm-2.10 which has yet to be released :/
Because i can't force all those poor distros to include unstable libs gparted has to stick to the current situation for the moment.

I'll look into your patch, but first i'd like to invent a new method for partitionhighlighting. Maybe drawing a semi-transparent blue rectangle over the selected partition will do the trick..

Comment 5 gnutter 2006-03-07 22:11:41 UTC
hmm, I was wondering about the overhead of that idea. Although cairo is powerful it is probably a bit over the top.

I had thought of another way to highlight , a straight line above and below the rectangle. It would perhaps be more noticable than the current method.

If semi-transparent blue rectangle means alpha blending just consider that not all video adapters or video drivers support that. It may endup solid blue or not rendered.

Comment 6 Plors (Bart H) 2006-03-09 13:28:14 UTC
Hi, i've been experimenting with alternate methods of highlighting the selected partition. Please have a look at the latest CVS and tell me what you think.
Comment 7 gnutter 2006-03-11 18:45:11 UTC
hmm, dont know. 

I think it is probably more noticable than the old method, I failed to notice the old highlight at first.

something seems a bit misplaced, I'll see if I get used to it .
Comment 8 Plors (Bart H) 2006-03-17 15:26:45 UTC
i've asked some people for their feedback and while they seem to like the 3D-effect they don't think it's very clear.
After some usage i tend to agree and i'm thinking about something else..

One person suggested to use a dotted, moving rectangle, much like the one used in the Gimp. I'll give it a try and see if it's any better.

In the meanwhile i'd appreciate your ideas/patches for improved highlighting.
Comment 9 Plors (Bart H) 2006-03-18 21:49:19 UTC
Hi, moving rectangles were nice to play with, but not really what i was looking for :)
I've settled for a dashed line with a width of 2px, i'm not 100% content with it, but i think i can live with it.

please let me know what you think of it.
Comment 10 gnutter 2006-03-18 22:37:31 UTC
Yes, I think is about the clearest yet.

I had thought of a horezontan red bar of similar width above and below the rectangle.

Probably would need to steal that space from the overall height but that should be OK.

Seems part of the problem here is the different heights of primary and extended.

Makes it tricky to give it a consistant look. Maybe you could reduce the primaries to the same height and keep the blue background to link the extended parts. together.

Comment 11 Plors (Bart H) 2006-03-18 23:19:04 UTC
>I had thought of a horezontan red bar of similar width above and below the
>rectangle.
that's very clear and also _very_ ugly ;)

I think i just keep it the way it is now (as long as i don't get too much negative feedback) and when cairo hits stable gtkmm, i'll redo the whole graphical partition display.

One thing i'm quite content with are the small borders (4px) this gives gparted a rather proffesional look ;)
Comment 12 gnutter 2006-03-18 23:25:24 UTC
yes I think the heavy borders was the main issue, it really did not fit with the rest.

I'll mark this closed. 8)