After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333760 - Allow for more extensive row background theming
Allow for more extensive row background theming
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other All
: Normal normal
: ---
Assigned To: Kristian Rietveld
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2006-03-07 16:08 UTC by Kristian Rietveld
Modified: 2006-04-26 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
first take at a patch (5.90 KB, patch)
2006-03-07 16:11 UTC, Kristian Rietveld 		none Details | Review

Description Kristian Rietveld 2006-03-07 16:08:48 UTC 
We could allow for more extensive row background theming, by drawing the backgrounds of the most left and most right columns differently (rounded corners, different color or gradient, whatever ;).

I am attaching a patch which adds a style property called "row-ending-detail", FALSE by default.  By default the old way of drawing the backgrounds (using one of cell_even, cell_odd, cell_even_ruled, etc, etc) will be used.

When that property is TRUE, "left", "middle", or "right" will be appended to the detail.  It will do this for the row backgrounds, focus cursor and drop indicator.

(I am not yet 100% sure about this feature, though).
Comment 1 Kristian Rietveld 2006-03-07 16:11:43 UTC 
Created attachment 60843 [details] [review]
first take at a patch

Oh, and I don't really like the snprintf() bit in there...
Comment 2 Matthias Clasen 2006-03-07 18:50:45 UTC 
do you have a screenshot of this in action ?
Comment 3 Kristian Rietveld 2006-03-07 20:20:25 UTC 
maemo-gtk, default theme (the cursor there has "rounded" corners (of only a single pixel though)).  No other screenshots, somebody will have to create a nice theme using this i guess ;)
Comment 4 Matthias Clasen 2006-03-08 17:04:18 UTC 
I agree that the  snprintf needs to go. Can't you just make those string constants
statics, and then compare pointers ?
Comment 5 Kristian Rietveld 2006-04-26 12:48:36 UTC 
We couldn't come up with a less messy plan for handling this, so the snprintfs stayed.  Committed on HEAD.