After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333486 - Wrong DVD speeds
Wrong DVD speeds
Status: RESOLVED FIXED
Product: nautilus-cd-burner
Classification: Deprecated
Component: cd-burner
2.13.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus CD Burner Maintainers
Nautilus CD Burner Maintainers
: 152428 349408 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-05 14:06 UTC by Fabio Bonelli
Modified: 2006-07-31 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (12.80 KB, patch)
2006-03-07 15:33 UTC, Fabio Bonelli
none Details | Review
patch (13.67 KB, patch)
2006-04-19 17:11 UTC, William Jon McCann
committed Details | Review

Description Fabio Bonelli 2006-03-05 14:06:27 UTC
n-c-b allows the selection of the writing speed, unfortunately there are two (really three) speeds:
- CD  speeds : 1x == 150 KB/s (176 for audio CDs)
- DVD speeds : 1x == 1385 KB/s

The speed is retrived from the drive's capabilities and *always* handled as a CD speed. My drives says it can write 2770 KB/s (DVD 2x) but we immediately convert that value to 15x (the *audio* CD speed) and use that value everywhere, even when writing DVD.

If the user selects 15x from the combo box and then write a DVD, we pass -speed=15 to growisofs, not "2". (as a side note, here this results in unreadable DVD because my can't write that fast).
Comment 1 Fabio Bonelli 2006-03-07 15:33:35 UTC
Created attachment 60838 [details] [review]
Patch
Comment 2 Fabio Bonelli 2006-03-07 15:41:39 UTC
This patch uses the right speed when writing the various media types.

It present a list of both the speeds in the form "CD 18 x, DVD 1 x" if the disc type cannot be determined, the list of CD speeds it the disc type is a CD and DVD speeds if the disc is a DVD. It also detect and update when a new disc is inserted.
Comment 3 Fabio Bonelli 2006-03-10 19:06:41 UTC
*** Bug 152428 has been marked as a duplicate of this bug. ***
Comment 4 Fabio Bonelli 2006-03-10 19:09:23 UTC
Keeping this one open because of the patch, but there are interesting comments in  bug 152428 for this issue.
Comment 5 William Jon McCann 2006-04-19 17:11:11 UTC
Created attachment 63887 [details] [review]
patch

Looks nice Fabio.

I've updated your patch with:

 * Remove unused NAUTILUS_BURN_DRIVE_MEDIA_TYPE_IS_CD 
 * Fix showing of Maximum possible in speed list
 * fix spacing in strings for dropdown list
 * Don't show DVD speeds for drives that aren't DVD recorders when no media in drive
Comment 6 William Jon McCann 2006-04-19 17:15:08 UTC
Fabio, if you want to follow all of the n-c-b bugs you can setup your bugzilla email preferences to watch the "nautilus-cd-burner-maint@gnome.bugs" user.

Nice work.
Comment 7 Fabio Bonelli 2006-04-19 21:24:31 UTC
Nice, thanks!
Comment 8 Fabio Bonelli 2006-07-31 21:25:15 UTC
*** Bug 349408 has been marked as a duplicate of this bug. ***