After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333266 - Registry file writing rewrite
Registry file writing rewrite
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-03-03 16:13 UTC by Michael Smith
Modified: 2006-04-27 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch for registry writing. (7.49 KB, patch)
2006-03-03 16:14 UTC, Michael Smith
none Details | Review
Alternative patch (11.63 KB, patch)
2006-03-03 17:04 UTC, Michael Smith
committed Details | Review

Description Michael Smith 2006-03-03 16:13:44 UTC
As described on the list and in the comment in this patch: rewrite how we write replacement registry files, to avoid various race conditions and to handle failed writes sanely. Fixes serious problems in a) out-of-disk-space, and b) starting 3 or more gstreamer applications simultaneously when a registry rewrite is required.

Attachment to come.
Comment 1 Michael Smith 2006-03-03 16:14:16 UTC
Created attachment 60577 [details] [review]
Patch for registry writing.
Comment 2 Michael Smith 2006-03-03 17:04:43 UTC
Created attachment 60580 [details] [review]
Alternative patch

Wim expressed concerns that the memory usage of this approach might be unreasonable on embedded systems.

I'm unconvinced (small embedded systems won't use the xml registry at all, medium sized embedded systems aren't going to have huge numbers of features/large registries, and large systems... well, still won't have huge numbers of features), but in the interests of getting the more serious issues addressed...

This version DOES have the possibility of leaving stale temp files around if we crash when writing the registry. I'm happy to commit either version, and/or take further comments.
Comment 3 Wim Taymans 2006-03-07 09:58:29 UTC
bounded memory usage sounds better to me. I'm not too concerned with leaving many tmp files around.
Comment 4 Michael Smith 2006-03-08 12:58:36 UTC
Ok, committed version that doesn't use a temporary memory buffer.