GNOME Bugzilla – Bug 332835
gimp-remote does not pass URIs properly
Last modified: 2008-01-15 14:05:58 UTC
Please describe the problem: GIMP is able to open remote files through the open dialog perfectly. However, gimp-remote seems to pass URIs in the form of a straight filename when used to open a file from Nautilus on a Windows share (or sftp). Changing the default action to call gimp directly results in the file opening as expected - obviously with the minor problem of opening a new instance of GIMP each time. Steps to reproduce: 1. Mount a remote share via Nautilus 2. Set up an action to call gnome-remote with the GnomeVFS URI 3. Open the file Actual results: An error dialog displays saying that "/home/jason/smb://jason@blah/blah/blah" can't be found Expected results: The image would open just like calling gimp directly. Does this happen every time? Yes Other information:
The check in gimp-remote whether a passed filename is an URI or not probably needs to be adjusted. It is somewhat naive and only deals with a fixed set of schemes.
The better fix however is to finally get rid of gimp-remote and build this functionality into the gimp application (see bug #52866).
Raising severity, we should really try to do something about this.
Created attachment 67868 [details] [review] Simple URI format checking This patch adds a new function in gimp-remote. This tryes to validate URI as <scheme>:<something>. <scheme> is defined as in RFC 2396 (part 3.1). <something> should not be empty.
I'd really have preferred if we folded gimp-remote into the core application. But let's apply this patch then and postpone that task to 2.6.
Applied with some minor coding style modifications. Thanks a lot for your patch. 2006-06-23 Sven Neumann <sven@gimp.org> * tools/gimp-remote.c: applied patch from Eric Lamarque that adds a new function to checks for a valid URI. Fixes bug #332835.