After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332736 - autocheck settings string in gdkevents-x11.c
autocheck settings string in gdkevents-x11.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-02-27 13:05 UTC by Tim Janik
Modified: 2006-02-27 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the described patch (10.53 KB, patch)
2006-02-27 13:07 UTC, Tim Janik 		none Details | Review

Description Tim Janik 2006-02-27 13:05:05 UTC 
the settings_names string and settings_map array in gdkevents-x11.c is fairly easy to get wrong. the attached patch moves the arrays into a seperate file so we can build a dedeicated test program which is also part of the patch.
Comment 1 Tim Janik 2006-02-27 13:07:24 UTC 
Created attachment 60230 [details] [review]
the described patch
Comment 2 Matthias Clasen 2006-02-27 13:28:43 UTC 
Looks fine to me; even better would be a little perl script to generate 
the list from a text file, similar to what we do for keynames.
Comment 3 Tim Janik 2006-02-27 13:58:09 UTC 
Mon Feb 27 14:52:50 2006  Tim Janik  <timj@imendio.com>

        * gdkevents-x11.c:
        * gdksettings.c: moved and renamed the gdk_settings_names and 
        gdk_settings_map.

        * gdk/x11/checksettings.c: test program for the gdk_settings_map array.

        * gdk/x11/Makefile.am: run checksettings as part of make check.