After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332580 - patch introduced in vte-0.11.16 completely breaks cyrillic rendering
patch introduced in vte-0.11.16 completely breaks cyrillic rendering
Status: RESOLVED DUPLICATE of bug 309322
Product: vte
Classification: Core
Component: general
0.11.x
Other Linux
: Normal major
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-25 22:42 UTC by Alexandre Rostovtsev
Modified: 2006-02-25 23:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
how vte currently renders cyrillic (10.54 KB, image/png)
2006-02-25 22:45 UTC, Alexandre Rostovtsev
Details
how vte should render cyrillic (12.83 KB, image/png)
2006-02-25 22:48 UTC, Alexandre Rostovtsev
Details

Description Alexandre Rostovtsev 2006-02-25 22:42:36 UTC
I use the Bitstream Vera Mono font in my terminal because it looks pretty and because it includes cyrillic characters (which I need). I found that vte-0.11.15 correctly rendered cyrillic characters using Bitstream Vera Mono, but all subsequent versions of vte (0.11.16 - 0.11.18) 
1. continue to render Latin text in Bitstream Vera Mono; but
2. render all cyrillic in some ugly ancient bitmapped X font; and
3. to add insult to injury, completely misrender that ancient font (when you are typing cyrillic now, the characters get partially rendered and jumbled together -- see screenshot attached).

I eventually tracked down the problem to 
http://cvs.gnome.org/viewcvs/vte/src/vtexft.c?r1=1.21&r2=1.22
which was a memory-saving patch introduced by Mike Hearn in
http://bugzilla.gnome.org/show_bug.cgi?id=309322

I don't know if that patch improves vte performance, but it certainly borks cyrillic rendering. I reverted it on my machine with no adverse effects.
Comment 1 Alexandre Rostovtsev 2006-02-25 22:45:56 UTC
Created attachment 60130 [details]
how vte currently renders cyrillic

This is how vte currently renders cyrillic (for the example text, I simply typed out the rows of the russian keyboard with spaces between). Observe that the font is some ancient abomination, and that once the string gets beyond a dozen characters or so, characters are getting jumbled up and misrendered.
Comment 2 Alexandre Rostovtsev 2006-02-25 22:48:53 UTC
Created attachment 60132 [details]
how vte should render cyrillic

And this is how vte renders cyrillic when I revert the memory-saving patch from src/vtexft.c 
Notice that now the text uses the correct font and the characters are no longer jumbled up.
Comment 3 Behdad Esfahbod 2006-02-25 22:52:37 UTC
Ah thanks.  I've been observing this too.  Will look into it.
Comment 4 Behdad Esfahbod 2006-02-25 23:02:01 UTC
Thanks for the report.  I'm reverting the patch as it makes no sense...

*** This bug has been marked as a duplicate of 309322 ***