GNOME Bugzilla – Bug 331838
build problem caused by AS_LIBTOOL_TAGS([CXX])
Last modified: 2006-03-28 14:24:26 UTC
+++ This bug was initially created as a clone of Bug #326683 +++
The point to keep the C++ configure stuff in gst-plugins-ugly may be gone as well.
Brian, can you comment on this bug? Should we not be adding the CXX tag here?
unlike the others, gst-plugins-ugly does contain a plugin that uses c++. It will become a problem again for gst-plugins-good at some point too, because there are other plugins in gst-plugins-bad that will probably move there eventually.
Is the C++ tag in the AS_LIBTOOL_TAGS macro really needed to build the C++
plugins? What breaks if the C++ argument is missing? The duplicate bug explains what breaks when you add it. If the C++ tag needs to go back in, then I can take a look at this again and see if there's another way I can fix the Solaris build problem.
"Is the C++ tag in the AS_LIBTOOL_TAGS macro really needed to build the C++
I have no idea - it's all autotools voodoo pain to me - I was hoping you'd know :)
Sorry, I don't know if it is needed. You'll have to test and see. If it is really needed for GStreamer to build properly, and this breaks the Solaris build again, then I'll find another way to fix the Solaris build.
But if GStreamer builds fine without the option, I don't see any need for adding it.
CC'ing thomas and andy for comment then - they're the dudes who are supposed to understand what this macro does.
I'll take this one, the macro is my fault :)
I can see the build problem here as well, and the patch from Bug #326683 remedies.
Created attachment 60751 [details] [review]
remove CXX autoconf foo
unbreaks the build :)
2006-03-27 Tim-Philipp Müller <tim at centricular dot net>
Patch by: Christian Kirbach
Remove CXX tag from AS_LIBTOOL_TAGS, just like we did for
-good. Fixes build on some systems (#331838).
I thought Andy was going to take this one, and actually fix it rather than disabling the CXX tag?
Ah, I didn't know there was anything else to fix. We've done the same thing for -good some time ago, so I don't think there are any downsides to just removing the tag.
Reopening then ...
aiui, there aren't until we go to reenable C++ based plugins at which point the tag is needed, or something. Andy understands, I believe.
In the meantime, we're probably ok to apply the patch (since there's no C++ based plugins building yet) and leave the bug open for Andy to fix.
As has been made apparent, I'm quite OK with ignoring the problem :-P
Just go ahead and close it I guess.