GNOME Bugzilla – Bug 331754
gconf settings for locking not clear and do not cover all possible options
Last modified: 2006-02-19 16:41:18 UTC
As explained in bug 331164 lock_ac_lid lock_battery_lid lock_button_suspend lock_sleep_idle do not cover all options. A better solution would be to do it by action So: lock_on_blank_screen lock_on_hibernate lock_on_suspend This covers all possible cases. Only possible issue with this that you cannot have different behaviour when you are on battery or on ac. But let me try to explain that that is not really an issue. For hibernate and suspend that is not an issue anyway. I don't see anybody wanting different locking behavior. So now for docking station If the laptop is already in the docking station we won't get a close lid event. So it's not an issue If it's not in we close it and before inserting it in the docking station we need to unplug the AC power adapter, because the laptop will receive power from the docking station. At least with the DELL docking stations I know. So I think it's also a non-issue here. Correct?? If not then we should have: lock_on_blank_screen_on_ac lock_on_blank_screen_on_battery lock_on_hibernate lock_on_suspend
I'm not sure this is fine grained enough. The whole rationale for having custom settings is so that we can specify *exactly* what we want the locking to do. Jon, what is your view? Jaap, I am willing to change the policy if you are sure you can cover all use-cases. I'll cc in Daniel and get his view also. Richard.
My whole point is that the current setup of gconf keys in CVS does not cover all possibilities. For example I cannot know what happens when I choose hibernate from the panel menu. The set: lock_on_blank_screen_on_ac lock_on_blank_screen_on_battery lock_on_hibernate lock_on_suspend covers all possibilities but as I argue in my previous comment lock_on_blank_screen_on_ac and lock_on_blank_screen_on_battery are not really necessary to seperate.
> For example I cannot know what happens when I choose hibernate from the panel menu. lock_on_menu_click Okay, I get your point. :-) lock_on_blank_screen lock_on_hibernate lock_on_suspend are probably enough. Got a patch or want me to do some work? Richard.
Haven't got a patch. Feel free to go for it ;-). I'll come up with a patch for the other stuff we are discussing currently
2006-02-19 Richard Hughes <richard@hughsie.com> * data/gnome-power-manager.schemas.in, src/gpm-prefs.h, src/gpm-manager.c: Only use lock_on_blank_screen, lock_on_suspend, lock_on_hibernate as this should give us enough power for custom users and also simplicity so we don't have a dozen keys. We default to gnome-screensaver settings.
Jaap, can you check this all works okay and then close this bug? It seems to work for me.