After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331356 - Allow constants in line widths, etc.
Allow constants in line widths, etc.
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Thomas Thurman
Metacity maintainers list
Depends on:
Blocks: 102547
 
 
Reported: 2006-02-16 02:22 UTC by Thomas Thurman
Modified: 2006-10-09 07:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to allow the use of constants in theme files anywhere you can use an integer literal (7.01 KB, patch)
2006-02-16 02:24 UTC, Thomas Thurman 		reviewed Details | Review

Description Thomas Thurman 2006-02-16 02:22:58 UTC 
While I was researching how to fix bug 129747, I noticed that many of the themes contained FIXMEs where their authors had wanted to use a constant for the width of a line, but had to use a literal because constants weren't supported.
Comment 1 Thomas Thurman 2006-02-16 02:24:31 UTC 
Created attachment 59443 [details] [review]
Patch to allow the use of constants in theme files anywhere you can use an integer literal

This is the patch I wrote to allow constants anywhere you could use a literal in theme files (and also to change those theme files to use constants, and to remove the FIXMEs).
Comment 2 Havoc Pennington 2006-02-16 05:46:16 UTC 
This is a little harder to fix than you might expect - see #102547

Patch itself is fine, if we ever break the theme format as described in that bug.
Comment 3 Elijah Newren 2006-02-19 15:52:05 UTC 
Marking patch as commented on to make it easier to find other patches needing review.
Comment 4 Thomas Thurman 2006-04-25 23:18:36 UTC 
Fixed in branch.
Comment 5 Elijah Newren 2006-04-25 23:23:25 UTC 
You might want to leave the bugs open until the stuff on the branch is merged to head (otherwise users try it out the latest version and complain that it isn't really fixed).
Comment 6 Thomas Thurman 2006-04-25 23:36:25 UTC 
Oh, good point.
Comment 7 Thomas Thurman 2006-10-07 17:02:30 UTC 
Fixed in HEAD!
Comment 8 Elijah Newren 2006-10-09 07:24:20 UTC 
Then marking as such...  ;-)