GNOME Bugzilla – Bug 330717
STATE_ABOVE is above dock layer
Last modified: 2006-02-11 23:58:57 UTC
in recent metacity, marking a window "On Top" causes it to be in a layer above the dock layer. I can't really imagine why this should be the case.
Is it actually above the dock layer or at the same level? If above, how do you duplicate? From here, all I see is that the above windows are in the same layer -- which I also see with gnome 2.12. Although stack.h defines them as separate levels, for some reason this appears to have been intentional according to the following ChangeLog entry: 2002-10-01 Havoc Pennington <hp@pobox.com> * src/stack.c (get_standalone_layer): put ABOVE windows in same layer as docks.
actually it is the same layer; guess I just never really noticed before. Still seems odd.
Yeah, maybe Havoc could tell us the reasoning. Havoc?
The effect of the change would be to have the focused item (dock or ABOVE window) end up on top, vs. having them in a fixed relation. (OK, stating the obvious.) I don't remember why I did it, but if nobody has complained in 3 years and there was some reason to do it in the first place, changing it back is probably just going to cause problems... maybe there's a bug with some related discussion, you could search for bugs closed/commented around that ChangeLog entry date...
Okay, I wasn't able to find a bug with relevant comments in my quick search. However, the EWMH explicitly recommends that ABOVE and DOCK should be in the same layer, which may have been the reason for the change. I do think it'd be worthwhile to clean up the code to make this more clear. I'll attach a patch in a minute that I'll commit which does so.
Created attachment 59160 [details] [review] Clarify the code on this point