After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330690 - vino should only advertise rfb deskop if enabled
vino should only advertise rfb deskop if enabled
Product: vino
Classification: Applications
Component: Server
Other All
: Normal normal
: ---
Assigned To: Jonh Wendell
Vino Maintainer(s)
Depends on:
Reported: 2006-02-10 16:53 UTC by j^
Modified: 2007-06-30 17:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Proposed patch (2.39 KB, patch)
2007-06-29 19:37 UTC, Jonh Wendell
committed Details | Review

Description j^ 2006-02-10 16:53:48 UTC
Please describe the problem:
right now vino will advertise 
"username's remote desktop._rfb._tcp.local" via avahi
no matter if it is enabled or not. this should only be advertised if 
 'Allow other users to view your desktop' is enabled.

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Mark McLoughlin 2006-10-23 10:28:40 UTC
The server shuts down 30 seconds after the Vino is disabled, at which point the service won't be advertised.

So, sure, there's a 30 second window in which the service might be advertised even though it's disabled

(Tempted to say it's not worth fixing it ... but it's probably pretty easy to fix so ...)
Comment 2 Jonh Wendell 2007-06-29 19:37:28 UTC
Created attachment 90897 [details] [review]
Proposed patch

Here it's my proposal.
Comment 3 Mark McLoughlin 2007-06-30 14:33:27 UTC
Yeah, it looks fine to commit

One thing I don't like is the way you need to be sure that vino_mdns_start() isn't called before the servers have been created (they need to add the services first), but it's not a big deal
Comment 4 Jonh Wendell 2007-06-30 17:55:58 UTC
2007-06-30  Jonh Wendell <>

	* server/vino-main.c,
	  server/vino-prefs.c: Only publish VNC service under Avahi when server
	  is enabled. Closes #330690.