GNOME Bugzilla – Bug 330690
vino should only advertise rfb deskop if enabled
Last modified: 2007-06-30 17:55:58 UTC
Please describe the problem:
right now vino will advertise
"username's remote desktop._rfb._tcp.local" via avahi
no matter if it is enabled or not. this should only be advertised if
'Allow other users to view your desktop' is enabled.
Steps to reproduce:
Does this happen every time?
The server shuts down 30 seconds after the Vino is disabled, at which point the service won't be advertised.
So, sure, there's a 30 second window in which the service might be advertised even though it's disabled
(Tempted to say it's not worth fixing it ... but it's probably pretty easy to fix so ...)
Created attachment 90897 [details] [review]
Here it's my proposal.
Yeah, it looks fine to commit
One thing I don't like is the way you need to be sure that vino_mdns_start() isn't called before the servers have been created (they need to add the services first), but it's not a big deal
2007-06-30 Jonh Wendell <email@example.com>
server/vino-prefs.c: Only publish VNC service under Avahi when server
is enabled. Closes #330690.